Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ProvisioningRequest service #6299

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

yaroslava-serdiuk
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

Implementing ProvisioningRequest service that is required for further implementation of ProvisioningRequest CRD proposal.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

https://github.com/kubernetes/autoscaler/blob/master/cluster-autoscaler/proposals/provisioning-request.md

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 20, 2023
@k8s-ci-robot k8s-ci-robot added area/cluster-autoscaler size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 20, 2023
@yaroslava-serdiuk yaroslava-serdiuk force-pushed the provreq branch 4 times, most recently from 3c7457e to d14fd9c Compare November 20, 2023 13:05
@yaroslava-serdiuk
Copy link
Contributor Author

/assign @kisieland

@k8s-ci-robot
Copy link
Contributor

@yaroslava-serdiuk: GitHub didn't allow me to assign the following users: kisieland.

Note that only kubernetes members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @kisieland

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@BigDarkClown BigDarkClown self-assigned this Nov 21, 2023
Copy link
Contributor

@BigDarkClown BigDarkClown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some preliminary comments about code style and testing, but I don't think I have enough in-depth knowledge about Provisioning Requests to judge how this implementation satisfies the requirements. @kisieland, could you review this change as well?

@yaroslava-serdiuk yaroslava-serdiuk force-pushed the provreq branch 3 times, most recently from 5a3efde to 76b7731 Compare November 23, 2023 11:47
Copy link
Contributor

@kisieland kisieland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BigDarkClown
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 27, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BigDarkClown, kisieland, yaroslava-serdiuk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 27, 2023
@k8s-ci-robot k8s-ci-robot merged commit 6998fd2 into kubernetes:master Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants