-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement ProvisioningRequest service #6299
Conversation
3c7457e
to
d14fd9c
Compare
/assign @kisieland |
@yaroslava-serdiuk: GitHub didn't allow me to assign the following users: kisieland. Note that only kubernetes members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some preliminary comments about code style and testing, but I don't think I have enough in-depth knowledge about Provisioning Requests to judge how this implementation satisfies the requirements. @kisieland, could you review this change as well?
cluster-autoscaler/provisioningrequest/service/v1beta1client/client.go
Outdated
Show resolved
Hide resolved
cluster-autoscaler/provisioningrequest/service/v1beta1client/client.go
Outdated
Show resolved
Hide resolved
cluster-autoscaler/provisioningrequest/service/v1beta1client/client.go
Outdated
Show resolved
Hide resolved
cluster-autoscaler/provisioningrequest/service/v1beta1client/testutils.go
Outdated
Show resolved
Hide resolved
cluster-autoscaler/provisioningrequest/service/v1beta1client/client_test.go
Show resolved
Hide resolved
5a3efde
to
76b7731
Compare
76b7731
to
4fd6e94
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BigDarkClown, kisieland, yaroslava-serdiuk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Implementing ProvisioningRequest service that is required for further implementation of ProvisioningRequest CRD proposal.
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
https://github.com/kubernetes/autoscaler/blob/master/cluster-autoscaler/proposals/provisioning-request.md