Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tencentcloud): remove dependency on tke interface #6140

Merged
merged 1 commit into from
Oct 10, 2023
Merged

feat(tencentcloud): remove dependency on tke interface #6140

merged 1 commit into from
Oct 10, 2023

Conversation

alphajc
Copy link
Contributor

@alphajc alphajc commented Sep 25, 2023

What type of PR is this?

/kind feature

Enable the open source cluster-autoscaler to run normally without relying on the TKE distribution.

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 25, 2023
@k8s-ci-robot k8s-ci-robot added area/cluster-autoscaler do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. labels Sep 25, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Sep 25, 2023
@alphajc alphajc force-pushed the master branch 5 times, most recently from cf90dfc to c810430 Compare September 25, 2023 23:27
@alphajc alphajc changed the title feat: remove dependency on tke interface feat(tencentcloud): remove dependency on tke interface Sep 26, 2023
@alphajc
Copy link
Contributor Author

alphajc commented Sep 28, 2023

Plz @mwielgus @BigDarkClown @feiskyer

@BigDarkClown
Copy link
Contributor

@alphajc I don't have context on tencentcloud cloudprovider specific changes. Changes which are entirely in the cloudprovider scope should be handled by cloudprovider owners. I see that there are no owners set for this provider, that's why this PR requires CA wide owners approval. Could we add some owners to this provider dir?

@BigDarkClown BigDarkClown self-assigned this Sep 29, 2023
@alphajc
Copy link
Contributor Author

alphajc commented Sep 30, 2023

@alphajc I don't have context on tencentcloud cloudprovider specific changes. Changes which are entirely in the cloudprovider scope should be handled by cloudprovider owners. I see that there are no owners set for this provider, that's why this PR requires CA wide owners approval. Could we add some owners to this provider dir?

@BigDarkClown of course, thx

@alphajc
Copy link
Contributor Author

alphajc commented Oct 9, 2023

/lgtm

@k8s-ci-robot
Copy link
Contributor

@alphajc: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@alphajc
Copy link
Contributor Author

alphajc commented Oct 9, 2023

@BigDarkClown Please help and see if there are any other issues that need to be addressed

mwielgus
mwielgus approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@mwielgus mwielgus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 10, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alphajc, mwielgus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 10, 2023
@k8s-ci-robot k8s-ci-robot merged commit 07df121 into kubernetes:master Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwielgus mwielgus mwielgus approved these changes

@BigDarkClown BigDarkClown Awaiting requested review from BigDarkClown

@feiskyer feiskyer Awaiting requested review from feiskyer

Assignees

@mwielgus mwielgus

@BigDarkClown BigDarkClown

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alphajc @BigDarkClown @k8s-ci-robot @mwielgus