-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow setting content-type in command #6114
Conversation
/assign @x13n |
I think it should be possible already to set content type through kubeconfig: https://github.com/kubernetes/client-go/blob/master/rest/config.go#L290 Isn't this sufficient? |
unfortunnately, kubeconfig is parsed with this Config type: https://github.com/kubernetes/client-go/blob/master/tools/clientcmd/api/types.go#L31, which has no content type field |
Signed-off-by: Eric Lin <[email protected]>
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: linxiulei, x13n The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Allow setting content-type in command line, which might be preferable for some users to use protobuf than json
Special notes for your reviewer:
Does this PR introduce a user-facing change
For more information on release notes see: https://git.k8s.io/community/contributors/guide/release-notes.md