Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[civo] Support pool wise config #5743

Merged
merged 4 commits into from
May 29, 2023
Merged

[civo] Support pool wise config #5743

merged 4 commits into from
May 29, 2023

Conversation

vishalanarase
Copy link
Member

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR allows civo customer to configure node pool wise config.

Which issue(s) this PR fixes:

Fixes #5742

@vishalanarase
[civo] Support pool wise config
cf3e309 
Signed-off-by: Vishal Anarse <[email protected]>
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 9, 2023
@k8s-ci-robot k8s-ci-robot requested a review from BigDarkClown May 9, 2023 02:32
@k8s-ci-robot k8s-ci-robot requested a review from feiskyer May 9, 2023 02:32
@vishalanarase vishalanarase mentioned this pull request May 10, 2023
Closed
9 tasks
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 21, 2023
@vishalanarase
Add example for node pool
ccb6a67 
Signed-off-by: Vishal Anarse <[email protected]>
@vishalanarase
Copy link
Member Author

@gjtempleton / @mwielgus Can you look please?

@gjtempleton
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 29, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gjtempleton, vishalanarase

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 29, 2023
@k8s-ci-robot k8s-ci-robot merged commit 97c12df into kubernetes:master May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BigDarkClown BigDarkClown Awaiting requested review from BigDarkClown

@feiskyer feiskyer Awaiting requested review from feiskyer

Assignees

@gjtempleton gjtempleton

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[civo] Support pool wise config
3 participants
@vishalanarase @gjtempleton @k8s-ci-robot