-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update x/http and x/net packages for VPA #5648
fix: update x/http and x/net packages for VPA #5648
Conversation
Welcome @knechtionscoding! |
@jbartosik Can we merge #5567 so people don't have to do these updates by hand? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@elmiko anything more needed from me to get this merged, or just sit tight and wait? First pr to autoscaler, so want to make sure I'm not missing anything in the process. |
@knechtionscoding i think this is in good shape, it needs approval from one of the VPA maintainers. we did talk about this at the last SIG meeting, i think @jbartosik was going to give a review at some point. |
@elmiko @jbartosik checking in on this to see if there's anything I can do to help move it forward? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: knechtionscoding, mwielgus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Resolves 4 high, 1 medium and 1 unknown vulnerability in the x/http and x/net packages by upgrading versions
Unit tests passed everywhere I could find them.
Which issue(s) this PR fixes:
Fixes #5647
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: