fix(cluster-autoscaler/hetzner): pre-existing volumes break scheduling #5322
Conversation
The `hcloud-csi-driver` v1.x uses the label `csi.hetzner.cloud/location` for topology. This label was not added in the response to `n.TemplateNodeInfo()`, causing cluster-autoscaler to not consider any node group for scaling when a pre-existing volume was attached to the pending pod. This is fixed by adding the appropriatly named label to the `NodeInfo`. In practice this label is added by the `hcloud-csi-driver`. In the upcoming v2 of the driver we migrated to using `apiv1.LabelZoneRegionStable` for topology constraints, but this fix is still required so customers do not have to re-create all `PersistentVolumes`. Further details on the bug are available in the original issue: hetznercloud/csi-driver#302
|
|
k8s-ci-robot
added
cncf-cla: no
k8s-ci-robot
added
cncf-cla: yes
|
Adding lgtm as @LKaemmerling reviewed and approved (through GitHub) but can not use the command as he is not a member of the org. /lgtm |
|
@apricote: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: apricote, LKaemmerling, mwielgus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Which component this PR applies to?
cluster-autoscaler
What type of PR is this?
/kind bug
What this PR does / why we need it:
The
hcloud-csi-driveruses the labelcsi.hetzner.cloud/locationfor topology. This label was not added in the response ton.TemplateNodeInfo(), causing cluster-autoscaler to not consider any node group for scaling when a pre-existing volume was attached to the pending pod.This is fixed by adding the appropriatly named label to the
NodeInfo. In practice this label is added by thehcloud-csi-driver.Which issue(s) this PR fixes:
Further details on the bug are available in the original issue: hetznercloud/csi-driver#302
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: