Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow simulator to persist changes in cluster snapshot #5131

Merged
merged 2 commits into from
Sep 15, 2022

Conversation

x13n
Copy link
Member

@x13n x13n commented Aug 26, 2022

Which component this PR applies to?

cluster-autoscaler

What type of PR is this?

/kind cleanup
/kind feature

What this PR does / why we need it:

One more refactor of existing scale down code in order to make parallel scale down (#5079) possible.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

This is a follow-up to #5118. Only last 2 commits should be reviewed as a part of this PR. It will be on hold until the previous one is merged.

/hold

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


/assign @MaciekPytel
/assign @yaroslava-serdiuk

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 26, 2022
@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 26, 2022
@x13n
Copy link
Member Author

x13n commented Aug 26, 2022

/retest

@x13n
Copy link
Member Author

x13n commented Aug 26, 2022

FWIW, looks like tests are failing due to #5134

@x13n
Copy link
Member Author

x13n commented Aug 26, 2022

/test test-and-verify

@k8s-ci-robot
Copy link
Contributor

@x13n: No presubmit jobs available for kubernetes/autoscaler@master

In response to this:

/test test-and-verify

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@x13n x13n force-pushed the scaledown2 branch 4 times, most recently from 22dfaa6 to f301804 Compare September 1, 2022 13:20
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 15, 2022
@x13n
Copy link
Member Author

x13n commented Sep 15, 2022

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 15, 2022
@MaciekPytel
Copy link
Contributor

/lgtm
/approve
Happy to see resource limits moved away to a separate file, I really hated how they were mixed up with scale-down code before.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 15, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MaciekPytel, x13n

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 15, 2022
@k8s-ci-robot k8s-ci-robot merged commit ab08e9a into kubernetes:master Sep 15, 2022
navinjoy pushed a commit to navinjoy/autoscaler that referenced this pull request Oct 26, 2022
Allow simulator to persist changes in cluster snapshot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants