-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow simulator to persist changes in cluster snapshot #5131
Conversation
/retest |
FWIW, looks like tests are failing due to #5134 |
/test test-and-verify |
@x13n: No presubmit jobs available for kubernetes/autoscaler@master In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
22dfaa6
to
f301804
Compare
/hold cancel |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MaciekPytel, x13n The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Allow simulator to persist changes in cluster snapshot
Which component this PR applies to?
cluster-autoscaler
What type of PR is this?
/kind cleanup
/kind feature
What this PR does / why we need it:
One more refactor of existing scale down code in order to make parallel scale down (#5079) possible.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
This is a follow-up to #5118. Only last 2 commits should be reviewed as a part of this PR. It will be on hold until the previous one is merged.
/hold
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
/assign @MaciekPytel
/assign @yaroslava-serdiuk