Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry-pick] Add ASG MixedInstancesPolicy Support 1.13 #2019

Conversation

danigrmartinez
Copy link

Related to 1.14 release cherrypick PR #2013

This is a cherrypick of the two PR. Code and documentation from @drewhemm
#1886
#1983

drewhemm added 2 commits May 15, 2019 02:49
* Enables the ASG instance type to be determined from the LaunchTemplate
default
* This makes it possible to have a mixed instance ASG, relying on AWS'
native logic for things like on-demand launch priority and spot
instances etc
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 15, 2019
@k8s-ci-robot k8s-ci-robot requested review from feiskyer and losipiuk May 15, 2019 09:58
@losipiuk
Copy link
Contributor

/lgtm
/approve
Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 15, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: losipiuk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 15, 2019
@losipiuk
Copy link
Contributor

@danigrmartinez for this one tests are failing. Please fix :)
/lgtm cancel

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 15, 2019
@Jeffwan
Copy link
Contributor

Jeffwan commented May 15, 2019

Looks like aws sdk doesn't have MixedInstancePolicy support in this version. Let me double verify it.

@danigrmartinez
Copy link
Author

@Jeffwan you are right. The versions of the AWS cli is not compatible with the new feature:

For 1.13

		{
			"ImportPath": "github.com/aws/aws-sdk-go/aws",
			"Comment": "v1.14.12",
			"Rev": "fde4ded7becdeae4d26bf1212916aabba79349b4"
		},

for 1.14:

		{
			"ImportPath": "github.com/aws/aws-sdk-go/aws",
			"Comment": "v1.16.26-2-g6f009370",
			"Rev": "6f009370adb66b6023fcea53c6aa8e93682b7151"
		},

In that case, I don't think we should include this on 1.13 or 1.12.

@danigrmartinez
Copy link
Author

Closing this because aws sdk version is not compratible with MixedInstancePolicy support

@Jeffwan
Copy link
Contributor

Jeffwan commented May 16, 2019

@danigrmartinez I remember the aws sdk version comes from kubernetes/kubernetes. If that's the true, there's a dependency and we can not easily upgrade it. Let me double check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants