-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cherry-pick] Add ASG MixedInstancesPolicy Support 1.13 #2019
[cherry-pick] Add ASG MixedInstancesPolicy Support 1.13 #2019
Conversation
* Enables the ASG instance type to be determined from the LaunchTemplate default * This makes it possible to have a mixed instance ASG, relying on AWS' native logic for things like on-demand launch priority and spot instances etc
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: losipiuk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@danigrmartinez for this one tests are failing. Please fix :) |
Looks like aws sdk doesn't have MixedInstancePolicy support in this version. Let me double verify it. |
@Jeffwan you are right. The versions of the AWS cli is not compatible with the new feature: For 1.13
for 1.14:
In that case, I don't think we should include this on 1.13 or 1.12. |
Closing this because aws sdk version is not compratible with MixedInstancePolicy support |
@danigrmartinez I remember the aws sdk version comes from kubernetes/kubernetes. If that's the true, there's a dependency and we can not easily upgrade it. Let me double check |
Related to 1.14 release cherrypick PR #2013
This is a cherrypick of the two PR. Code and documentation from @drewhemm
#1886
#1983