Set State to InstanceCreating for nodes that failed to join cluster

kubernetes · Jul 30, 2024 · 0dd9ea5 · 0dd9ea5
1 parent 3914bde
commit 0dd9ea5
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/cluster-autoscaler/cloudprovider/oci/nodepools/oci_manager.go b/cluster-autoscaler/cloudprovider/oci/nodepools/oci_manager.go
@@ -390,6 +390,7 @@ func (m *ociManagerImpl) GetNodePoolNodes(np NodePool) ([]cloudprovider.Instance
 			instances = append(instances, cloudprovider.Instance{
 				Id: *node.Id,
 				Status: &cloudprovider.InstanceStatus{
+					State: cloudprovider.InstanceCreating,
 					ErrorInfo: &cloudprovider.InstanceErrorInfo{
 						ErrorClass:   errorClass,
 						ErrorCode:    *node.NodeError.Code,

diff --git a/cluster-autoscaler/cloudprovider/oci/nodepools/oci_manager_test.go b/cluster-autoscaler/cloudprovider/oci/nodepools/oci_manager_test.go
@@ -154,6 +154,7 @@ func TestGetNodePoolNodes(t *testing.T) {
 		{
 			Id: "node6",
 			Status: &cloudprovider.InstanceStatus{
+				State: cloudprovider.InstanceCreating,
 				ErrorInfo: &cloudprovider.InstanceErrorInfo{
 					ErrorClass:   cloudprovider.OtherErrorClass,
 					ErrorCode:    "unknown",
@@ -164,6 +165,7 @@ func TestGetNodePoolNodes(t *testing.T) {
 		{
 			Id: "node7",
 			Status: &cloudprovider.InstanceStatus{
+				State: cloudprovider.InstanceCreating,
 				ErrorInfo: &cloudprovider.InstanceErrorInfo{
 					ErrorClass:   cloudprovider.OutOfResourcesErrorClass,
 					ErrorCode:    "LimitExceeded",
@@ -174,6 +176,7 @@ func TestGetNodePoolNodes(t *testing.T) {
 		{
 			Id: "node8",
 			Status: &cloudprovider.InstanceStatus{
+				State: cloudprovider.InstanceCreating,
 				ErrorInfo: &cloudprovider.InstanceErrorInfo{
 					ErrorClass:   cloudprovider.OutOfResourcesErrorClass,
 					ErrorCode:    "InternalServerError",