Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ship a Gopkg.toml #23

Closed
lavalamp opened this issue Sep 7, 2017 · 6 comments
Closed

Ship a Gopkg.toml #23

lavalamp opened this issue Sep 7, 2017 · 6 comments
Assignees
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@lavalamp
Copy link
Member

lavalamp commented Sep 7, 2017

...to help dep users get the correct version of dependencies (e.g., k8s.io/apimachinery).

@sttts
Copy link
Contributor

sttts commented Sep 7, 2017

To avoid duplicated work, I have prototype code for the publishing bot to do this when a release tag from the kube repo is converted into one of the published repo. Obviously, the Gopkg.toml should not reference sha1 revisions, but tags, for client-go preferably the semver tag.

@lavalamp
Copy link
Member Author

lavalamp commented Sep 7, 2017 via email

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 4, 2018
@sttts
Copy link
Contributor

sttts commented Jan 4, 2018

/assign
/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Jan 4, 2018
@nikhita
Copy link
Member

nikhita commented Mar 4, 2018

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 4, 2018
@nikhita
Copy link
Member

nikhita commented Jul 4, 2019

We have go.mod now, so closing. :)

@nikhita nikhita closed this as completed Jul 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Development

No branches or pull requests

5 participants