Add default-fs parameter to provisioner args

[RaunakShah]

What this PR does / why we need it:
This PR adds a default fs type parameter to external provisioner. With v2.0.0, provisioner sends an empty fs type parameter if none is specified, instead of defaulting to ext4. Reference: kubernetes-csi/external-provisioner#328
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes ##370

Special notes for your reviewer:

Release note:

Add default-fs parameter to provisioner args

[RaunakShah]

jtest vanilla-file

[RaunakShah]

jtest vanilla-block

[divyenpatel]

/approve

[SandeepPissay]

The code change looks good to me. Lets wait for the E2E test results.

/approve

[RaunakShah]

jtest block-vanilla

[RaunakShah]

jtest file-vanilla

[svcbot-qecnsdp]

Started Vanilla block pipeline...

[svcbot-qecnsdp]

Started vanilla file pipeline...

[svcbot-qecnsdp]

File vanilla build status: FAILURE 
Stage before exit: testbed-deploy 

[svcbot-qecnsdp]

Block vanilla build status: FAILURE 
Stage before exit: e2e-tests 
Jenkins E2E Test Results: 
Ran 34 of 149 Specs in 7284.595 seconds
FAIL! -- 32 Passed | 2 Failed | 0 Pending | 115 Skipped
--- FAIL: TestE2E (7284.62s)
FAIL

Ginkgo ran 1 suite in 2h1m47.592654069s
Test Suite Failed
make: Leaving directory `/home/worker/workspace/github-csi-block-vanilla/Results/154/vsphere-csi-driver`

[RaunakShah]

Couple of block tests are failing due to connection issues with VC:

21:11:21    Unexpected error:
21:11:21        <task.Error>: {
21:11:21            LocalizedMethodFault: {
21:11:21                DynamicData: {},
21:11:21                Fault: {
21:11:21                    RuntimeFault: {
21:11:21                        MethodFault: {FaultCause: nil, FaultMessage: nil},
21:11:21                    },
21:11:21                },
21:11:21                LocalizedMessage: "An error occurred while communicating with the remote host.",
21:11:21            },
21:11:21        }
21:11:21        An error occurred while communicating with the remote host.
21:11:21    occurred

Will rerun file tests since the testbed failed to deploy.

[RaunakShah]

jtest file-vanilla

[svcbot-qecnsdp]

Started vanilla file pipeline...

[svcbot-qecnsdp]

File vanilla build status: FAILURE 
Stage before exit: testbed-deploy 

[RaunakShah]

jtest file-vanilla

[svcbot-qecnsdp]

Started vanilla file pipeline...

[svcbot-qecnsdp]

File vanilla build status: FAILURE 
Stage before exit: e2e-tests 
Jenkins E2E Test Results: 
Ran 24 of 149 Specs in 2457.567 seconds
FAIL! -- 22 Passed | 2 Failed | 0 Pending | 125 Skipped
--- FAIL: TestE2E (2457.59s)
FAIL

Ginkgo ran 1 suite in 41m18.546107541s
Test Suite Failed
make: Leaving directory `/home/worker/workspace/github-csi-file-vanilla/Results/95/vsphere-csi-driver`

[RaunakShah]

File vanilla build status: FAILURE 
Stage before exit: e2e-tests 
Jenkins E2E Test Results: 
Ran 24 of 149 Specs in 2457.567 seconds
FAIL! -- 22 Passed | 2 Failed | 0 Pending | 125 Skipped
--- FAIL: TestE2E (2457.59s)
FAIL

Ginkgo ran 1 suite in 41m18.546107541s
Test Suite Failed
make: Leaving directory `/home/worker/workspace/github-csi-file-vanilla/Results/95/vsphere-csi-driver`

One failure was due to timeout with etcd server:

01:04:17    Unexpected error:
01:04:17        <*errors.errorString | 0xc0009b7a10>: {
01:04:17            s: "pod \"pvc-tester-589zg\" was not deleted: etcdserver: request timed out",
01:04:17        }
01:04:17        pod "pvc-tester-589zg" was not deleted: etcdserver: request timed out
01:04:17    occurred

Another test failed because we dont yet block RWO AccessMode PVC creation for file volumes:

01:35:49  STEP: Creating Storage Class with access mode "ReadWriteOnce" and fstype "nfs4"
...
01:35:49  STEP: Expect claim to fail as the access mode "ReadWriteOnce" is not supported for File volumes
...
01:36:20  
01:36:20    Unable to verify pvc create failure
01:36:20    Expected
01:36:20        <bool>: false
01:36:20    to be true

[divyenpatel]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: divyenpatel, RaunakShah, SandeepPissay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [RaunakShah,SandeepPissay,divyenpatel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[divyenpatel]

/lgtm