-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin cri-o and redhat-actions/push-to-registry #749
Conversation
Signed-off-by: Paulo Gomes <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pjbgf, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test pull-security-profiles-operator-test-e2e |
Codecov Report
@@ Coverage Diff @@
## main #749 +/- ##
=======================================
Coverage 54.03% 54.03%
=======================================
Files 42 42
Lines 4129 4129
=======================================
Hits 2231 2231
Misses 1831 1831
Partials 67 67 |
/test pull-security-profiles-operator-test-e2e |
2 similar comments
/test pull-security-profiles-operator-test-e2e |
/test pull-security-profiles-operator-test-e2e |
/test pull-security-profiles-operator-test-e2e |
/test pull-security-profiles-operator-test-e2e |
What type of PR is this?
/kind cleanup
What this PR does
Why we need it:
Pinned dependencies reduce several security risks:
More information refer to ossf
Which issue(s) this PR fixes:
Relates to #653
Does this PR have test?
N/A
Special notes for your reviewer:
Once this PR is merged, there is only one valid item dependency to be pinned (as per reported by ossf scorecard), which is the build base image:
https://github.com/kubernetes-sigs/security-profiles-operator/blob/main/Dockerfile#L16
This item will be remediated in the coming weeks.
The ossf scorecard also reported a few items within the
vendor
folder, but I am treating it as false positive (ossf/scorecard#1095).Does this PR introduce a user-facing change?