Implement sakkara scheduler plugin

[atantawi]

What type of PR is this?

/kind feature

What this PR does / why we need it:

Implement ClusterTopologyPlacementGroup plugin

Which issue(s) this PR fixes:

Fixes #

Addresses Kubernetes Enhancement Proposal: 4986-kep-sakkara

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: atantawi
Once this PR has been reviewed and has the lgtm label, please assign ffromani for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Hi @atantawi. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[netlify]

✅ Deploy Preview for kubernetes-sigs-scheduler-plugins canceled.

Name	Link
🔨 Latest commit	f0ddf9d
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-scheduler-plugins/deploys/67a250ffce2c2a00082dc217

[googs1025]

/ok-to-test

[13567436138]

awesome

[13567436138]

func (pl *ClusterTopologyPlacementGroup) PostFilter(ctx context.Context, state *framework.CycleState,
	pod *v1.Pod, filteredNodeStatusMap framework.NodeToStatusMap) (*framework.PostFilterResult, *framework.Status) {

	logger := klog.FromContext(ctx)
	podName := pod.GetName()
	nameSpace := pod.GetNamespace()
	groupName := GetGroupNameFromPod(pod)
	groupKey := CreateGroupKey(groupName, nameSpace)

	// check if zombie pod
	if pl.state.IsPodDeleted(pod) {
		logger.V(6).Info("PostFilter: zombie pod, already deleted, skipping", "podName", podName)
		return nil, framework.NewStatus(framework.Unschedulable,
			fmt.Sprintf("Pod %s in group %s already deleted, skipping", podName, groupKey))
	}

	group, groupExists := pl.state.GetGroup(groupKey)

	if !groupExists || group == nil {
		logger.V(6).Info("PostFilter: pod member of unknown group, skipping", "podName", podName)
		return nil, framework.NewStatus(framework.Unschedulable, "done PostFilter")
	}

	member := group.GetMember(pod)
	if member == nil {
		logger.V(6).Info("PostFilter: pod not member of group", "podName", podName, "groupName", groupName)
		return nil, framework.NewStatus(framework.Unschedulable, "done PostFilter")
	}
	if member.Status == Preempting {
		logger.V(6).Info("PostFilter: pod already marked Preempting", "podName", podName, "group", groupKey)
		return nil, framework.NewStatus(framework.Unschedulable, "done PostFilter")
	}

	logger.V(6).Info("PostFilter: attempting preemption ...")
	if group.GetStatus() == Preempting {
		logger.V(6).Info("PostFilter: group has already preempted", "podName", podName, "group", groupKey)
		return nil, framework.NewStatus(framework.Unschedulable, "done PostFilter")
	}
	if err := pl.attemptPreemption(pod, groupKey, logger); err != nil {
		logger.V(6).Info("PostFilter: attempt preemption failed", "err", err)
	}
	return nil, framework.NewStatus(framework.Unschedulable, "done PostFilter")
}

why postFilter return nil finally,
if err := pl.attemptPreemption(pod, groupKey, logger); err != nil {
logger.V(6).Info("PostFilter: attempt preemption failed", "err", err)
}
here should it return error

[13567436138]

if I use podgroup,does the controllers be needed?