-
Notifications
You must be signed in to change notification settings - Fork 545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix leader election config in the helm chart #815
Fix leader election config in the helm chart #815
Conversation
Hi @chotiwat. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for kubernetes-sigs-scheduler-plugins canceled.
|
resourceNamespace: {{ .Release.Namespace }} | ||
resourceName: {{ .Values.scheduler.name }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test |
@chotiwat thanks for the PR. Could you add a brief stanza in the |
Done @Huang-Wei |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chotiwat, Huang-Wei The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
The default leader election for kube-scheduler will try to acquire the
kube-system/kube-scheduler
lease, which is what the default scheduler uses. This prevents our custom scheduler from ever acquiring the leader lease until the leader loses the lease, at which point it could cause undesirable behavior by stealing the lease from the default scheduler. We should be using a separate lease if we want to run the custom scheduler alongside the default scheduler.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?