Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an issue that build params are not propagated #777

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

Huang-Wei
Copy link
Contributor

What type of PR is this?

/kind bug

What this PR does / why we need it:

Fix an issue that build params are not propagated.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 29, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Huang-Wei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 29, 2024
Copy link

netlify bot commented Jul 29, 2024

Deploy Preview for kubernetes-sigs-scheduler-plugins canceled.

Name Link
🔨 Latest commit 832645d
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-scheduler-plugins/deploys/66a70bdcc105bd000893005b

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 29, 2024
@Huang-Wei
Copy link
Contributor Author

A UT flake:

--- FAIL: TestNetworkOverheadScore (3.11s)
    --- FAIL: TestNetworkOverheadScore/AppGroup:_basic,_p2_to_allocate,_8_nodes_to_score (1.10s)
        networkoverhead_test.go:790: Workload: p2-deployment; Node: n-1; score: 0; status: Success; message: Accumulated cost added as score, normalization ensures lower costs are favored 
        networkoverhead_test.go:790: Workload: p2-deployment; Node: n-2; score: 0; status: Success; message: Accumulated cost added as score, normalization ensures lower costs are favored 
        networkoverhead_test.go:790: Workload: p2-deployment; Node: n-3; score: 0; status: Success; message: Accumulated cost added as score, normalization ensures lower costs are favored 
        networkoverhead_test.go:790: Workload: p2-deployment; Node: n-4; score: 0; status: Success; message: Accumulated cost added as score, normalization ensures lower costs are favored 
        networkoverhead_test.go:790: Workload: p2-deployment; Node: n-5; score: 0; status: Success; message: Accumulated cost added as score, normalization ensures lower costs are favored 
        networkoverhead_test.go:790: Workload: p2-deployment; Node: n-6; score: 0; status: Success; message: Accumulated cost added as score, normalization ensures lower costs are favored 
        networkoverhead_test.go:790: Workload: p2-deployment; Node: n-7; score: 0; status: Success; message: Accumulated cost added as score, normalization ensures lower costs are favored 
        networkoverhead_test.go:790: Workload: p2-deployment; Node: n-8; score: 0; status: Success; message: Accumulated cost added as score, normalization ensures lower costs are favored 
        networkoverhead_test.go:800: [Score] status does not match: [{n-1 0} {n-2 0} {n-3 0} {n-4 0} {n-5 0} {n-6 0} {n-7 0} {n-8 0}], want: [{n-1 0} {n-2 1} {n-3 5} {n-4 5} {n-5 20} {n-6 20} {n-7 20} {n-8 20}]
        networkoverhead_test.go:810: [Normalize] status does not match: [{n-1 0} {n-2 0} {n-3 0} {n-4 0} {n-5 0} {n-6 0} {n-7 0} {n-8 0}], want: [{n-1 100} {n-2 95} {n-3 75} {n-4 75} {n-5 0} {n-6 0} {n-7 0} {n-8 0}]
FAIL
FAIL	sigs.k8s.io/scheduler-plugins/pkg/networkaware/networkoverhead	11.862s
ok  	sigs.k8s.io/scheduler-plugins/pkg/networkaware/topologicalsort	0.863s
ok  	sigs.k8s.io/scheduler-plugins/pkg/noderesources	0.[52](https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_scheduler-plugins/777/pull-scheduler-plugins-unit-test-master/1817763650597818368#1:build-log.txt%3A52)2s
ok  	sigs.k8s.io/scheduler-plugins/pkg/noderesourcetopology	1.305s
ok  	sigs.k8s.io/scheduler-plugins/pkg/noderesourcetopology/cache	1.100s
ok  	sigs.k8s.io/scheduler-plugins/pkg/noderesourcetopology/nodeconfig	0.301s
9 skipped lines...
ok  	sigs.k8s.io/scheduler-plugins/pkg/trimaran/targetloadpacking	0.199s
ok  	sigs.k8s.io/scheduler-plugins/pkg/util	0.086s
ok  	sigs.k8s.io/scheduler-plugins/apis/config/scheme	0.102s
ok  	sigs.k8s.io/scheduler-plugins/apis/config/v1	0.018s
ok  	sigs.k8s.io/scheduler-plugins/apis/config/validation	0.009s
FAIL
make: *** [Makefile:90: unit-test] Error 1

@Huang-Wei
Copy link
Contributor Author

/retest

@Huang-Wei Huang-Wei merged commit d4204aa into kubernetes-sigs:master Jul 29, 2024
9 of 10 checks passed
@Huang-Wei Huang-Wei deleted the fix-build branch July 29, 2024 03:45
@Huang-Wei
Copy link
Contributor Author

/cherrypick release-1.29

@k8s-infra-cherrypick-robot

@Huang-Wei: new pull request created: #779

In response to this:

/cherrypick release-1.29

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants