solve struct literal uses unkeyed fields

[maoqide]

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

• solve complaints of struct literal uses unkeyed fields when go vet.

Which issue(s) this PR fixes:

Fixes # NONE

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: maoqide (bbfd0ab, bbf6965)

[k8s-ci-robot]

Welcome @maoqide!

It looks like this is your first PR to kubernetes-sigs/scheduler-plugins 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/scheduler-plugins has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @maoqide. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[netlify]

✅ Deploy Preview for kubernetes-sigs-scheduler-plugins canceled.

Name	Link
🔨 Latest commit	bbfd0ab
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-scheduler-plugins/deploys/66d02042b2c436000820731d

[ffromani]

/ok-to-test

hi, thanks for this contribution! since the project CI passes cleanly so far, which run of go vet highlighted these issues?

[maoqide]

/ok-to-test

hi, thanks for this contribution! since the project CI passes cleanly so far, which run of go vet highlighted these issues?

running go vet ./... under project root directory, output like:

# sigs.k8s.io/scheduler-plugins/pkg/networkaware/networkoverhead
# [sigs.k8s.io/scheduler-plugins/pkg/networkaware/networkoverhead]
pkg/networkaware/networkoverhead/networkoverhead_test.go:289:29: k8s.io/apimachinery/pkg/apis/meta/v1.Time struct literal uses unkeyed fields
pkg/networkaware/networkoverhead/networkoverhead_test.go:290:29: k8s.io/apimachinery/pkg/apis/meta/v1.Time struct literal uses unkeyed fields
pkg/networkaware/networkoverhead/networkoverhead_test.go:334:23: k8s.io/apimachinery/pkg/apis/meta/v1.Time struct literal uses unkeyed fields
pkg/networkaware/networkoverhead/networkoverhead_test.go:334:73: k8s.io/apimachinery/pkg/apis/meta/v1.Time struct literal uses unkeyed fields
# sigs.k8s.io/scheduler-plugins/pkg/networkaware/topologicalsort
# [sigs.k8s.io/scheduler-plugins/pkg/networkaware/topologicalsort]
pkg/networkaware/topologicalsort/topologicalsort_test.go:108:29: k8s.io/apimachinery/pkg/apis/meta/v1.Time struct literal uses unkeyed fields
pkg/networkaware/topologicalsort/topologicalsort_test.go:109:29: k8s.io/apimachinery/pkg/apis/meta/v1.Time struct literal uses unkeyed fields
pkg/networkaware/topologicalsort/topologicalsort_test.go:149:23: k8s.io/apimachinery/pkg/apis/meta/v1.Time struct literal uses unkeyed fields
pkg/networkaware/topologicalsort/topologicalsort_test.go:149:73: k8s.io/apimachinery/pkg/apis/meta/v1.Time struct literal uses unkeyed fields
# sigs.k8s.io/scheduler-plugins/test/integration
# [sigs.k8s.io/scheduler-plugins/test/integration]
test/integration/networkoverhead_test.go:185:22: k8s.io/apimachinery/pkg/apis/meta/v1.Time struct literal uses unkeyed fields
test/integration/networkoverhead_test.go:185:72: k8s.io/apimachinery/pkg/apis/meta/v1.Time struct literal uses unkeyed fields
test/integration/topologicalsort_test.go:148:22: k8s.io/apimachinery/pkg/apis/meta/v1.Time struct literal uses unkeyed fields
test/integration/topologicalsort_test.go:148:72: k8s.io/apimachinery/pkg/apis/meta/v1.Time struct literal uses unkeyed fields
test/integration/topologicalsort_test.go:225:22: k8s.io/apimachinery/pkg/apis/meta/v1.Time struct literal uses unkeyed fields
test/integration/topologicalsort_test.go:225:72: k8s.io/apimachinery/pkg/apis/meta/v1.Time struct literal uses unkeyed fields

[ffromani]

we should perhaps tighten the CI rules after the necessary cleanups are merged (cc @Huang-Wei for awareness)

could you please sign the CLA @maoqide ? it's a prerequisite to be able to contribute. Thanks!

[maoqide]

could you please sign the CLA @maoqide ? it's a prerequisite to be able to contribute. Thanks!

OK. Thanks!

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle stale
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[Huang-Wei]

we can simplify this as metav1.Now()

[maoqide]

yes, you're right. I have updated the code.

[Huang-Wei]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Huang-Wei, maoqide

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Huang-Wei]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Huang-Wei]

/release-note-none