site: add chart index to site #737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so that we can use site as chart repo Signed-off-by: Wei Zhang <[email protected]>
k8s-ci-robot
added
kind/documentation
k8s-ci-robot
added
cncf-cla: yes
✅ Deploy Preview for kubernetes-sigs-scheduler-plugins ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
after this one merge, we can use the site as chart repo like: the URL should be https://scheduler-plugins.sigs.k8s.io/ after merged to master kweizh@weim /tmp> helm repo add pr https://deploy-preview-737--kubernetes-sigs-scheduler-plugins.netlify.app
"pr" has been added to your repositories
kweizh@weim /tmp> helm repo update pr
Hang tight while we grab the latest from your chart repositories...
...Successfully got an update from the "pr" chart repository
Update Complete. ⎈Happy Helming!⎈
kweizh@weim /tmp> helm search repo pr
NAME CHART VERSION APP VERSION DESCRIPTION
pr/scheduler-plugins 0.28.8 0.28.8 deploy scheduler plugin as a second scheduler i... |
|
It's fabulous @zwpaper ! Cannot wait to see its publish. Could you reword the release notes a bit? something like: |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Huang-Wei, zwpaper The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
release note updated, PTAL @Huang-Wei |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind documentation
What this PR does / why we need it:
add chart index to site so that we can use the site as chart repo,
and pull chart from our github releases
Which issue(s) this PR fixes:
Fixes #620
Special notes for your reviewer:
Does this PR introduce a user-facing change?