Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove manual edit strings from crd manifests #699

Merged
merged 1 commit into from
Jan 28, 2024

Conversation

Huang-Wei
Copy link
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

With this PR, CRDs hosted in this repo or referenced in externals repos are recommended to add:

// +kubebuilder:metadata:annotations="api-approved.kubernetes.io=https://github.com/kubernetes-sigs/scheduler-plugins/pull/XYZ"

to their types.go, but not mandatory.

hack/verify-crdgen.sh is able to catch any inconsistency between types.go and CRD manifests.

Which issue(s) this PR fixes:

A follow-up of #479.

Special notes for your reviewer:

Does this PR introduce a user-facing change?

+kubebuilder:metadata:annotations is recommended but no longer mandatory to be defined in CRD types.go

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Jan 27, 2024
Copy link

netlify bot commented Jan 27, 2024

Deploy Preview for kubernetes-sigs-scheduler-plugins canceled.

Name Link
🔨 Latest commit 2cef193
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-scheduler-plugins/deploys/65b547292de938000837e87d

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 27, 2024
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 27, 2024
@Huang-Wei
Copy link
Contributor Author

@lianghao208 could you please help review?

@Huang-Wei Huang-Wei requested a review from lianghao208 January 27, 2024 18:11
@lianghao208
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 28, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Huang-Wei, lianghao208

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit c752c54 into kubernetes-sigs:master Jan 28, 2024
10 checks passed
@Huang-Wei Huang-Wei deleted the update-crd-yamls branch January 28, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants