Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Sprig template functions and add asLabelValue function #2038

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use Sprig template functions and add asLabelValue function #2038

wants to merge 1 commit into from

Conversation

fahhem
Copy link

@fahhem fahhem commented Jan 29, 2025

Fixes #2033

@k8s-ci-robot k8s-ci-robot added do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 29, 2025
@k8s-ci-robot
Copy link
Contributor

Welcome @fahhem!

It looks like this is your first PR to kubernetes-sigs/node-feature-discovery 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/node-feature-discovery has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @fahhem. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 29, 2025
@netlify Netlify
Copy link

netlify bot commented Jan 29, 2025 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-nfd ready!

Name Link
🔨 Latest commit 6d97803
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-nfd/deploys/67a40115ca90bb0008f5ca77
😎 Deploy Preview https://deploy-preview-2038--kubernetes-sigs-nfd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Jan 29, 2025
@fahhem fahhem mentioned this pull request Jan 29, 2025
Open
TessaIO
TessaIO reviewed Jan 30, 2025
View reviewed changes
pkg/utils/template.go Outdated Show resolved Hide resolved
marquiz
marquiz reviewed Jan 30, 2025
View reviewed changes
Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @fahhem for the contribution. That was quick 😄 A few comments below.

Also, could you update the documentation (https://kubernetes-sigs.github.io/node-feature-discovery/v0.16/usage/customization-guide.html#templating) to mention that the sprig funcs are supported?

pkg/utils/template.go Outdated Show resolved Hide resolved
pkg/utils/template.go Outdated Show resolved Hide resolved
@marquiz
Copy link
Contributor

marquiz commented Jan 30, 2025

/cc @ArangoGutierrez

@marquiz
Copy link
Contributor

marquiz commented Jan 30, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 30, 2025
@fahhem
Copy link
Author

fahhem commented Jan 30, 2025

Looks like all the tests pass now!

marquiz
marquiz reviewed Jan 31, 2025
View reviewed changes
Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fahhem thanks for the update, looks very good now, just two small nits/suggestions below. I think you could also squash the commits into one.

pkg/utils/template.go Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 31, 2025
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 31, 2025
@fahhem fahhem force-pushed the sprig-template branch 2 times, most recently from 7f32417 to f401f20 Compare January 31, 2025 17:31
@fahhem
Copy link
Author

fahhem commented Jan 31, 2025

/retest

@fahhem fahhem requested a review from marquiz February 1, 2025 00:43
@fahhem
Copy link
Author

fahhem commented Feb 5, 2025

I don't understand why that test is failing, there's no tracebacks or anything, it just dies after 2 hours

@marquiz
Copy link
Contributor

marquiz commented Feb 5, 2025

I don't understand why that test is failing, there's no tracebacks or anything, it just dies after 2 hours

Ach, that is some flake in the cross-build (arm64) builds that I'm not sure why it gets stuck. Just need to re-test until it succeeds
/retest

@marquiz
Copy link
Contributor

marquiz commented Feb 5, 2025

Thanks @fahhem for the update. I put my review comment in a form of a PR
SonicInfra#1

If you think that is ok you can just squash it into your commit.

@fahhem
Copy link
Author

fahhem commented Feb 6, 2025

Thanks! I'll squash them now

@fahhem
Copy link
Author

fahhem commented Feb 6, 2025

/retest

marquiz
marquiz approved these changes Feb 6, 2025
View reviewed changes
Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, looks good to me now

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fahhem, marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 6, 2025
@marquiz
Copy link
Contributor

marquiz commented Feb 6, 2025

/assign @ArangoGutierrez

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TessaIO TessaIO TessaIO left review comments

@marquiz marquiz marquiz approved these changes

@adrianchiris adrianchiris Awaiting requested review from adrianchiris

@ArangoGutierrez ArangoGutierrez Awaiting requested review from ArangoGutierrez

Assignees

@ArangoGutierrez ArangoGutierrez

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use Sprig template functions
5 participants
@fahhem @k8s-ci-robot @marquiz @TessaIO @ArangoGutierrez