Set namespace for auth-reader rb to kube-system

[hamza3202]

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1231

[k8s-ci-robot]

Welcome @hamza3202!

It looks like this is your first PR to kubernetes-sigs/metrics-server 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/metrics-server has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @hamza3202. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[stevehipwell]

/ok-to-test

[stevehipwell]

/triage accepted

[stevehipwell]

/retest

[stevehipwell]

/retest

[stevehipwell]

/retest

[stevehipwell]

/retest

[stevehipwell]

/approve

@serathius could you take a look and give this a LGTM?

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hamza3202, stevehipwell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• charts/OWNERS [stevehipwell]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[serathius]

I can lgtm, but don't know much about running metrics server in namespaces other than kube-system. In standard deployment we just don't allow alternative namespaces. It might not be the only bug in Helm chart with running MS in other namespaces.

/ltgm

[stevehipwell]

@serathius this PR is just reverting a typo I made. I think you miss spelt the LGTM.

[hamza3202]

@serathius can you please fix the typo so that this can proceed?

[serathius]

/lgtm

[hamza3202]

Might be a bit too late to ask this but what is the release process for this helm chart? Should I also have updated the chart version or is that something done separately?

[stevehipwell]

@hamza3202 I've got another couple of issues/PRs to look at and then I might create a PR to release the chart. As @serathius said in his reply, Metrics Server is expected to be run in kube-system which is why this wasn't picked up as a bug. I wanted the PR for correctness not necessarily to support running in an alternate namespace.

[hamza3202]

My 2 cents on the above discussion:
We have been running metrics server in its own namespace without any issues.
We use a managed kubernetes solution and so we prefer to do only strictly required changes in the kube-system namespace and setup everything else in dedicated namespaces.

You may not have intentionally supported this but nevertheless it used to work before and it would be great if it started working again as well so that things may not un-intentionally break for others.

[stevehipwell]

@hamza3202 this change will be released by #1244