Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Helm Chart Repo Names and Remove ConfigHome Tmp Dir for Better Helm Integration #5864

Closed
wants to merge 4 commits into from

Conversation

isarns
Copy link
Contributor

@isarns isarns commented Feb 16, 2025

This PR introduces support for using Helm chart repository names when specifying helmCharts in Kustomize. Instead of requiring the full repository URL, users can now reference a repository added via the helm repo add command.

Example Usage:

helmCharts:
- name: minecraft
  version: 3.1.3
  repo: minecraft-server-charts
  releaseName: moria
  valuesInline:
    minecraftServer:
      eula: true
      difficulty: hard
      rcon:
        enabled: true
    resources:
      requests:
        cpu: 500m
        memory: 512Mi
  valuesMerge: replace

This allows users to reference repositories added via:

helm repo add minecraft-server-charts https://itzg.github.io/minecraft-server-charts/

Additional Improvements:

Why This Matters:

  • Private Helm Repository Support:
    • This is a significant step toward native support for private Helm repositories in Kustomize without requiring credentials to be passed manually.
  • Future Integration with ArgoCD:
    • This lays the groundwork for an ArgoCD PR that would allow Helm credentials to be passed to Kustomize applications.
    • This addresses a longstanding request that was previously blocked by Kustomize’s "Helm long-term plan."

This PR enhances the flexibility and usability of Helm integration within Kustomize, particularly for users managing private repositories. 🚀

Related Issues That This PR May Help Solve

@k8s-ci-robot
Copy link
Contributor

This PR has multiple commits, and the default merge method is: merge.
You can request commits to be squashed using the label: tide/merge-method-squash

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: isarns
Once this PR has been reviewed and has the lgtm label, please assign varshaprasad96 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 16, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @isarns. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 16, 2025
@koba1t
Copy link
Member

koba1t commented Feb 17, 2025

Hi @isarns

The use of temporary directories when running Helm is intended.
This is to avoid side effects when building with kustomize build and to ensure that Helm behaves the same regardless of which environment it is run from.
This is also stipulated in the Eschewed Features, and I would have a hard time accepting such a feature as I do not want to further increase the complexity caused by the execution environment during the kustomize build run.

ref: #4401

If you want to introduce a new feature for any open-source project, I recommend creating an issue and discussing that feature before starting work, as this helps you avoid unnecessary work.

/close

@k8s-ci-robot
Copy link
Contributor

@koba1t: Closed this PR.

In response to this:

Hi @isarns

The use of temporary directories when running Helm is intended.
This is to avoid side effects when building with kustomize build and to ensure that Helm behaves the same regardless of which environment it is run from.
This is also stipulated in the Eschewed Features, and I would have a hard time accepting such a feature as I do not want to further increase the complexity caused by the execution environment during the kustomize build run.

ref: #4401

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants