-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Helm Chart Repo Names and Remove ConfigHome Tmp Dir for Better Helm Integration #5864
Conversation
This PR has multiple commits, and the default merge method is: merge. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: isarns The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @isarns. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Hi @isarns The use of temporary directories when running Helm is intended. ref: #4401 If you want to introduce a new feature for any open-source project, I recommend creating an issue and discussing that feature before starting work, as this helps you avoid unnecessary work. /close |
@koba1t: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This PR introduces support for using Helm chart repository names when specifying
helmCharts
in Kustomize. Instead of requiring the full repository URL, users can now reference a repository added via thehelm repo add
command.Example Usage:
This allows users to reference repositories added via:
Additional Improvements:
ConfigHome
directory.https://
,http://
, andoci://
private Helm repositories.Why This Matters:
This PR enhances the flexibility and usability of Helm integration within Kustomize, particularly for users managing private repositories. 🚀
Related Issues That This PR May Help Solve
helmCharts
repo field doesn't work with OCI registry #4381