-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Functionality that Pulls Env Variables from Empty Keys #4957
Remove Functionality that Pulls Env Variables from Empty Keys #4957
Conversation
Skipping CI for Draft Pull Request. |
182abb6
to
0859d5d
Compare
0859d5d
to
5107a0b
Compare
62945ad
to
3841894
Compare
3841894
to
b7746d0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/hold for @natasha41575 to approve as well
Co-authored-by: Katrina Verey <[email protected]>
@cailynse: This PR has multiple commits, and the default merge method is: merge. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold cancel
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cailynse, KnVerey, natasha41575 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Addresses: #4731
Instead of pulling in environment values when a key is added in the env file with out the
=
we will now treat this case the same as if an=
is present and set the value to an empty string.