Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Functionality that Pulls Env Variables from Empty Keys #4957

Conversation

cailyn-codes
Copy link
Contributor

Addresses: #4731

Instead of pulling in environment values when a key is added in the env file with out the = we will now treat this case the same as if an = is present and set the value to an empty string.

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jan 4, 2023
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 4, 2023
@cailyn-codes cailyn-codes changed the title [WIP]: Remove Functionality that Pull Env Variables from Empty Keys [WIP]: Remove Functionality that Pulls Env Variables from Empty Keys Jan 4, 2023
@cailyn-codes cailyn-codes force-pushed the update-configMapGenerator-4731 branch 2 times, most recently from 182abb6 to 0859d5d Compare January 4, 2023 21:51
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 4, 2023
@cailyn-codes cailyn-codes force-pushed the update-configMapGenerator-4731 branch from 0859d5d to 5107a0b Compare January 5, 2023 15:58
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 5, 2023
@cailyn-codes cailyn-codes force-pushed the update-configMapGenerator-4731 branch 2 times, most recently from 62945ad to 3841894 Compare January 5, 2023 16:00
@cailyn-codes cailyn-codes force-pushed the update-configMapGenerator-4731 branch from 3841894 to b7746d0 Compare January 5, 2023 17:55
@cailyn-codes cailyn-codes changed the title [WIP]: Remove Functionality that Pulls Env Variables from Empty Keys Remove Functionality that Pulls Env Variables from Empty Keys Jan 5, 2023
@cailyn-codes cailyn-codes marked this pull request as ready for review January 5, 2023 18:51
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 5, 2023
@k8s-ci-robot k8s-ci-robot requested a review from KnVerey January 5, 2023 18:51
Copy link
Contributor

@KnVerey KnVerey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/hold for @natasha41575 to approve as well

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 5, 2023
Co-authored-by: Katrina Verey <[email protected]>
@k8s-ci-robot
Copy link
Contributor

@cailynse: This PR has multiple commits, and the default merge method is: merge.
You can request commits to be squashed using the label: tide/merge-method-squash

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@KnVerey KnVerey added the release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. label Jan 5, 2023
Copy link
Contributor

@natasha41575 natasha41575 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 5, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 5, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cailynse, KnVerey, natasha41575

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [KnVerey,natasha41575]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants