-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve localizer
readability
#4860
Improve localizer
readability
#4860
Conversation
@annasong20: This PR has multiple commits, and the default merge method is: merge. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/label tide/merge-method-squash |
4b33348
to
ad6348f
Compare
I think we want to find a better name to replace
|
|
ah, I see. |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: annasong20, natasha41575 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Replace '%s' with %q * Change ambiguous cli-"Arg" suffix in func arg names * Remove repetitive "loc" in names * Apply readability changes to localizer * Fix comment
This PR aims to improve the readability of code under
api/internal/localizer
. Specifically, it addresses readability-related code review feedback from #4797.