-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api/internal/git: handle .git suffix in repospec #4039
api/internal/git: handle .git suffix in repospec #4039
Conversation
Welcome @zhouhaibing089! |
Hi @zhouhaibing089. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This change adds a new test case for parsing url with `.git` suffix. In that case, we should have the full url as clone spec with an empty abspath.
866e9de
to
8c14b9d
Compare
/ok-to-test |
/lgtm Waiting for tests to pass before approving |
/approve Thank you! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brianpursley, natasha41575, zhouhaibing089 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This change adds a new test case for parsing url with
.git
suffix. Inthat case, we should have the full url as clone spec with an empty
abspath.
This fixes #4011.