-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resource urls don't support ports #4622
Comments
/triage accepted I have no objection to implementing this if there is demand for it, but would consider it low priority. |
Just for reference, this is a blocker for my team as we enforce ssh on a specific port within our orgs self managed GitLab. |
FYI, I don't know why, but the https port sub-test asks the user to enter their username and password. The result is the same regardless of whether the user enters their credentials. However, if the user does, the sub-test takes about 1/2 the time to run. |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close not-planned |
@k8s-triage-robot: Closing this issue, marking it as "Not Planned". In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Describe the bug
Our remote targets specification supports git clone urls, which can include a port. However, when specifying a port in urls under the
resources
field, I get an error.Files that can reproduce the issue
The TestRemoteResourcePort test case in remoteload_test.go currently throws errors, though it shouldn't.
Note that the ssh sub-test will locally run without error once this port issue is resolved. However, the ssh sub-test will still fail on the server, unless the server acquires ssh keys. We skip this sub-test for the same reason.
Expected output
We currently compare the output of TestRemoteResourcePort to the errors kustomize throws from its inability to process the ports. The actual expected output of a successful build is the value of the variable multiBaseDevExampleBuild.
Actual output
The current output is an error, which is specified in TestRemoteResourcePort.
Kustomize version
We observe this behavior on the master branch, at commit 17b42a9.
The text was updated successfully, but these errors were encountered: