Test api for all platforms and skip those breaking on Windows

kubernetes-sigs · Jun 16, 2021 · b129a72 · b129a72
1 parent 7fae7d1
commit b129a72
Show file tree

Hide file tree

Showing 5 changed files with 16 additions and 0 deletions.
diff --git a/.github/workflows/go.yml b/.github/workflows/go.yml
@@ -45,6 +45,10 @@ jobs:
         run: go test -cover ./...
         working-directory: ./kyaml
 
+      - name: Test api
+        run: go test -cover ./... -ldflags "-X sigs.k8s.io/kustomize/api/provenance.version=v444.333.222"
+        working-directory: ./api
+
       - name: Test cmd/config
         run: go test -cover ./...
         working-directory: ./cmd/config
@@ -69,6 +73,10 @@ jobs:
         run: go test -cover ./...
         working-directory: ./kyaml
 
+      - name: Test api
+        run: go test -cover ./... -ldflags "-X sigs.k8s.io/kustomize/api/provenance.version=v444.333.222"
+        working-directory: ./api
+
       - name: Test cmd/config
         run: go test -cover ./...
         working-directory: ./cmd/config
@@ -93,6 +101,10 @@ jobs:
         run: go test -cover ./...
         working-directory: ./kyaml
 
+      - name: Test api
+        run: go test -cover ./... -ldflags "-X sigs.k8s.io/kustomize/api/provenance.version=v444.333.222"
+        working-directory: ./api
+
       - name: Test cmd/config
         run: go test -cover ./...
         working-directory: ./cmd/config

diff --git a/kyaml/filesys/confirmeddir_test.go b/kyaml/filesys/confirmeddir_test.go
@@ -2,6 +2,7 @@
 // SPDX-License-Identifier: Apache-2.0
 
 // +build !windows
+// TODO: Make these tests pass on Windows too.
 
 package filesys
 

diff --git a/kyaml/filesys/fsnode_test.go b/kyaml/filesys/fsnode_test.go
@@ -2,6 +2,7 @@
 // SPDX-License-Identifier: Apache-2.0
 
 // +build !windows
+// TODO: Make these tests pass on Windows too.
 
 package filesys
 

diff --git a/kyaml/filesys/fsondisk_test.go b/kyaml/filesys/fsondisk_test.go
@@ -2,6 +2,7 @@
 // SPDX-License-Identifier: Apache-2.0
 
 // +build !windows
+// TODO: Make these tests pass on Windows too.
 
 package filesys
 

diff --git a/kyaml/filesys/util_test.go b/kyaml/filesys/util_test.go
@@ -2,6 +2,7 @@
 // SPDX-License-Identifier: Apache-2.0
 
 // +build !windows
+// TODO: Make these tests pass on Windows too.
 
 package filesys