Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[site] Run RayJobs #780

Merged
merged 1 commit into from
May 24, 2023
Merged

Conversation

trasc
Copy link
Contributor

@trasc trasc commented May 18, 2023

What type of PR is this?

/kind documentation

What this PR does / why we need it:

Adds documentation on how to run a RayJob

Which issue(s) this PR fixes:

Ralates to #666

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/documentation Categorizes issue or PR as related to documentation. labels May 18, 2023
@k8s-ci-robot k8s-ci-robot requested review from denkensk and kerthcet May 18, 2023 15:21
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 18, 2023
@netlify
Copy link

netlify bot commented May 18, 2023

Deploy Preview for kubernetes-sigs-kueue ready!

Name Link
🔨 Latest commit 430990d
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/646713f85bdccd0008d940f2
😎 Deploy Preview https://deploy-preview-780--kubernetes-sigs-kueue.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 18, 2023
@trasc
Copy link
Contributor Author

trasc commented May 18, 2023

/cc @alculquicondor

Should I target this to main or website-v0.4.0 ?

@alculquicondor
Copy link
Contributor

website-v0.4.0

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 19, 2023
@trasc trasc changed the base branch from main to website-release-0.4 May 19, 2023 06:15
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 19, 2023
site/content/en/docs/installation/_index.md Outdated Show resolved Hide resolved
site/content/en/docs/tasks/run_rayjobs.md Outdated Show resolved Hide resolved
site/content/en/docs/tasks/run_rayjobs.md Outdated Show resolved Hide resolved
site/content/en/docs/tasks/run_rayjobs.md Outdated Show resolved Hide resolved
site/content/en/docs/tasks/run_rayjobs.md Show resolved Hide resolved
site/content/en/docs/tasks/run_rayjobs.md Outdated Show resolved Hide resolved
site/content/en/docs/tasks/run_rayjobs.md Outdated Show resolved Hide resolved
site/content/en/docs/tasks/run_rayjobs.md Outdated Show resolved Hide resolved
Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly, LGTM. I left a few comments for nits.

site/content/en/docs/tasks/run_rayjobs.md Outdated Show resolved Hide resolved
@tenzen-y
Copy link
Member

/lgtm
/assign @alculquicondor

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 22, 2023
@alculquicondor
Copy link
Contributor

/approve
/hold

Let's wait for the implementation PR to merge (it's in my review queue)

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 24, 2023
@alculquicondor
Copy link
Contributor

/milestone v0.4

@k8s-ci-robot k8s-ci-robot added this to the v0.4 milestone May 24, 2023
@alculquicondor
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, trasc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@alculquicondor
Copy link
Contributor

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 24, 2023
@k8s-ci-robot k8s-ci-robot merged commit b81cf7a into kubernetes-sigs:website-release-0.4 May 24, 2023
@trasc trasc deleted the ray-doc branch May 25, 2023 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants