Config option to select which job framework integrations should be enabled #668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/cleanup
k8s-ci-robot
added
the
cncf-cla: yes
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
k8s-ci-robot
added
the
size/L
|
/assign @alculquicondor |
mwielgus
force-pushed
the
integrations
branch
5 times, most recently
from
27ac4c9 to
8132c09
Compare
mwielgus
force-pushed
the
integrations
branch
5 times, most recently
from
ad819fe to
ae06df7
Compare
There was a problem hiding this comment.
Could you restore the original file?
There was a problem hiding this comment.
No, the ordering of stuff in main changed and I guess that impacts the order in manifest.
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor, mwielgus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/retest |
Merged
Please make sure there is an open issue for a flaky test before retesting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
/kind feature
What this PR does / why we need it:
Currently all framework integrations are enabled, causing error logs on startup if the corresponding CRDs are not there. This PR adds a config option to select which integrations should be enabled and defaults it to k8s job only.
Which issue(s) this PR fixes:
Fixes #665
Special notes for your reviewer: