Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CentOS typo #11161

Merged
merged 1 commit into from
May 6, 2024
Merged

Conversation

VannTen
Copy link
Contributor

@VannTen VannTen commented May 3, 2024

What type of PR is this?
/kind bug

What this PR does / why we need it:
The name reported in ansible_distribution is "CentOS", so this could
break some things.
Fix a typo in #11131

Does this PR introduce a user-facing change?:

NONE

The name reported in ansible_distribution is "CentOS", so this could
break some things.
@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label May 3, 2024
@k8s-ci-robot k8s-ci-robot requested review from MrFreezeex and mzaian May 3, 2024 14:27
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 3, 2024
Copy link
Member

@MrFreezeex MrFreezeex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix 🎉
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 3, 2024
@VannTen
Copy link
Contributor Author

VannTen commented May 4, 2024 via email

@yankay
Copy link
Member

yankay commented May 6, 2024

Thanks @VannTen
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MrFreezeex, VannTen, yankay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 6, 2024
@k8s-ci-robot k8s-ci-robot merged commit 4cb688d into kubernetes-sigs:master May 6, 2024
60 checks passed
dibi-codes pushed a commit to fino-digital/kubespray that referenced this pull request May 7, 2024
The name reported in ansible_distribution is "CentOS", so this could
break some things.
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
The name reported in ansible_distribution is "CentOS", so this could
break some things.
Rickkwa pushed a commit to Rickkwa/kubespray that referenced this pull request Jun 26, 2024
The name reported in ansible_distribution is "CentOS", so this could
break some things.
davidumea pushed a commit to elastisys/kubespray that referenced this pull request Oct 25, 2024
The name reported in ansible_distribution is "CentOS", so this could
break some things.
kpoxo6op pushed a commit to kpoxo6op/kubespray that referenced this pull request Dec 27, 2024
The name reported in ansible_distribution is "CentOS", so this could
break some things.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants