Makefile: docker-build should use --load for newer docker build aliased to buildx

[kaovilai]

…ed to buildx

Fixes #4546

Same as migtools/oadp-non-admin#180

Related: #4545

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kaovilai
Once this PR has been reviewed and has the lgtm label, please assign kavinjsir for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Hi @kaovilai. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[camilamacedo86]

Hi @kaovilai 👋

Really appreciate you taking the time to improve Kubebuilder! 🚀

I hope you don’t mind, but I’ll close this PR with the following reference:
Issue #4546 - Comment.

If you disagree and still think we should add this change,
please feel free to reopen the PR for further discussion.

Thanks again for your contribution! 😊

[camilamacedo86]

It is the default docker build and it is working fine. We should not add the flag here.

You probably want to replace the --flag push with --load in the docker buildX instead, see: https://github.com/kubernetes-sigs/kubebuilder/pull/4547/files#diff-e5d6d4f9d67174f1f3764674eb786688353c77cef8514e24d1323e55e5a4a7e8R192-R209

However, the WARNING is only faced in the buildx(above target) when it has no flags --load or --push You removed it from your own project.

[kaovilai]

docker buildx build --push do not require --load at all.. if you have --push, you can skip --load.

[camilamacedo86]

Hi @kaovilai

See: #4546 (comment)

I reproduce your scenario:

You are calling docker buildx without ANY of the flags.
It is required to have --load or push

And this target here is docker build ( should not use any of those )
You can either validate the behaviour with the samples under testdata to check that all generated by Kubebuilder works fine.

So, I am closing this one as deferred if you do not mind

[kaovilai]

@camilamacedo86 per #4546 (comment) this can be triggered with just docker-build per my reproduce. I did not modify the default scaffold.

[kaovilai]

This is one of the PRs that benefits the users of the default scaffold without modification.

[camilamacedo86]

Closing this based on the comment : #4546 (comment).

We should not do this change.
But thank you a lot for raising it and trying to contribute to the project.