-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 (go/v4): Fix linter issues in the scaffold #4111
🐛 (go/v4): Fix linter issues in the scaffold #4111
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
a6d1408
to
8062a42
Compare
This PR fix the following issues: ``` $ make lint testdata/project-v4/bin/golangci-lint run cmd/main.go:154:37: string has 3 occurrences, make it a constant (goconst) if os.Getenv(ENABLE_WEBHOOKS) != false { ^ api/v1/firstmate_webhook.go:25:5: var is unused (unused) var firstmatelog = logf.Log.WithName(firstmate-resource) ```
8062a42
to
e4ef218
Compare
I am moving forward because it is a nit/fix |
This PR fix the following issues: