-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Upgrade the k8s to 1.26.1 and controller-runtime to 0.14.2 #3197
✨ Upgrade the k8s to 1.26.1 and controller-runtime to 0.14.2 #3197
Conversation
Hi @yashsingh74. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
cc: @varshaprasad96 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
You probably need to ensure that your branch is rebase with master and run make generate to update the samples, Could you please to do that to sorted out the CI that is failing? |
…from 0.14.1 to 0.14.2 Signed-off-by: Yash Singh <[email protected]>
1abb0be
to
f4a8032
Compare
I did the rebase but it doesn't show git conflicts. Also, I ran the |
/test pull-kubebuilder-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @yashsingh74! Everything looks good. There is just one suggestion on bumping the controller-tools version since we haven't merged this PR yet and there is already a patch release with a bug fix in c-t (0.11.3).
@@ -34,7 +34,7 @@ import ( | |||
|
|||
const ( | |||
// ControllerRuntimeVersion is the kubernetes-sigs/controller-runtime version to be used in the project | |||
ControllerRuntimeVersion = "v0.14.1" | |||
ControllerRuntimeVersion = "v0.14.2" | |||
// ControllerToolsVersion is the kubernetes-sigs/controller-tools version to be used in the project | |||
ControllerToolsVersion = "v0.11.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we haven't merged this PR yet, and controller-tools has a v0.11.3 release (https://github.com/kubernetes-sigs/controller-tools/blob/v0.11.3/go.mod#L16) that uses k8s 1.26.1, it would be nice to bump it here too. We can do it in a follow up as well, but would be helpful to track it with a comment or an issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@varshaprasad96, I think we can do the bump in a follow up wdyt?
Shows that we also have a new controller-runtime version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll go ahead and merge this!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, varshaprasad96, yashsingh74 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The APIDiff test is expected to fail. Once the controller-tools comment is addressed, I can override the test and merge it. |
/override go-apidiff |
@varshaprasad96: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Upgrade the version and the respective dependencies
Fixes: #3195