📖 docs: supplement plugin creation #3008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
Kavinjsir
changed the title
Kavinjsir
force-pushed
the
docs/external-plugin
branch
2 times, most recently
from
7c260a1 to
0f4e27c
Compare
Kavinjsir
force-pushed
the
docs/external-plugin
branch
from
0f4e27c to
4c32e18
Compare
k8s-ci-robot
added
size/L
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
Kavinjsir
changed the title
There was a problem hiding this comment.
Hi @Kavinjsir,
I am ok with the changes made. Are you still working on this one OR is it all done for us to review and get it merged?
k8s-ci-robot
added
the
needs-rebase
Kavinjsir
force-pushed
the
docs/external-plugin
branch
from
4c32e18 to
ad75e8c
Compare
k8s-ci-robot
removed
the
needs-rebase
|
/unhold |
k8s-ci-robot
removed
the
do-not-merge/hold
Kavinjsir
changed the title
Kavinjsir
force-pushed
the
docs/external-plugin
branch
from
ad75e8c to
e735bdf
Compare
Hi @camilamacedo86 , thx for reviewing! I'm sorry to be late and do not make the update quite match to our basic idea. If the current acceptable, I'm also good to get it merge for now and create a following PR as enhancement. |
camilamacedo86
approved these changes
Oct 25, 2022
k8s-ci-robot
added
the
approved
Kavinjsir
force-pushed
the
docs/external-plugin
branch
from
e735bdf to
25b8355
Compare
Kavinjsir
force-pushed
the
docs/external-plugin
branch
from
25b8355 to
637f85a
Compare
varshaprasad96
approved these changes
Nov 1, 2022
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, Kavinjsir, varshaprasad96 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a section in
create-pluginto provide references for users who create the plugin to scaffold on top of whatcreate apibrings.Motivation
Resolve: #2874