Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 add dependency bot updates #2957

Merged
merged 1 commit into from
Sep 28, 2022
Merged

🌱 add dependency bot updates #2957

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 49 additions & 0 deletions .github/dependabot.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,49 @@
# To get started with Dependabot version updates, you'll need to specify which
# package ecosystems to update and where the package manifests are located.
# Please see the documentation for all configuration options:
# https://docs.github.com/github/administering-a-repository/configuration-options-for-dependency-updates

version: 2
updates:

# Maintain dependencies for GitHub Actions
- package-ecosystem: "github-actions"
# Workflow files stored in the
# default location of `.github/workflows`
directory: "/"
schedule:
interval: "weekly"
commit-message:
prefix: ":seedling:"
labels:
- "ok-to-test"

# Maintain dependencies for go
- package-ecosystem: "gomod"
directory: "/"
schedule:
interval: "weekly"
labels:
- "ok-to-test"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this work for go dependencies used by the testdata? When I bumped ginkgo, make test failed until I ran make generate?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The label only allows the tests be executed. Just that.
Also, note that this action is just to open PR's with updates in the github actions. So, it has no relation with make generate at all. The make generate re-generate the samples projects scaffold under testdata to ensure that the scaffolds matches with the latest changes (it only fails/or is required when you do prs to change the scaffolds)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. My thought was if dependabot for example bumps ginkgo (~go get -u github.com/onsi/ginkgo/v2) and makes a pr, then GH actions will automatically run make test and it would fail. But this isn't a big worry for me and I could be wrong here.


# Maintain dependencies for dockerfile in the branches
- package-ecosystem: docker
directory: "/build/thirdparty/darwin"
target-branch: "tools-releases"
schedule:
interval: daily
- package-ecosystem: docker
directory: "/build/thirdparty/linux"
target-branch: "tools-releases"
schedule:
interval: "weekly"

# Maintain dependencies for dockerfile scaffold in the projects
- package-ecosystem: docker
directory: "testdata/project-v3"
schedule:
interval: daily
- package-ecosystem: docker
directory: "testdata/project-v4"
schedule:
interval: "weekly"