-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨Include base.go.kubebuilder.io/v3 plugin in CLI #2350
✨Include base.go.kubebuilder.io/v3 plugin in CLI #2350
Conversation
Signed-off-by: Adam Snyder <[email protected]>
Hi @armsnyder. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test Seems fine to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, the change here would allow scaffold only the base for go/v3 instead of the full plugin.
I am ok with that.
However, for you to use KB to create your own plugins I'd suggest you use it as lib and not the CLI. See: #2349 (comment)
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: armsnyder, camilamacedo86 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Registers the existing
base.go.kubebuilder.io/v3
plugin so that it is usable in thekubebuilder
CLI, for users who do not use Kustomize.Updated supported plugin table:
Closes #2349
Signed-off-by: Adam Snyder [email protected]