Kubebuilder doesn't respect +default

[pmalek]

Problem statement

As per https://book.kubebuilder.io/reference/markers/crd-validation, kubebuilder respects its own +kubebuilder:default. It would be beneficial for end users to also respect +default.

Related issues/PRs

• fix(api): make LocalObjectReference.Name and HostAlias.IP required kubernetes/kubernetes#124553

Proposed solution

• Naive

  Add support in controller-tools:

  diff --git a/pkg/crd/markers/validation.go b/pkg/crd/markers/validation.go
  index 06d1cab6..aaae336c 100644
  --- a/pkg/crd/markers/validation.go
  +++ b/pkg/crd/markers/validation.go
  @@ -91,6 +91,8 @@ var FieldOnlyMarkers = []*definitionWithHelp{
   
      must(markers.MakeAnyTypeDefinition("kubebuilder:default", markers.DescribesField, Default{})).
    	  WithHelp(Default{}.Help()),
  +	must(markers.MakeAnyTypeDefinition("default", markers.DescribesField, Default{})).
  +		WithHelp(Default{}.Help()),
   
      must(markers.MakeAnyTypeDefinition("kubebuilder:example", markers.DescribesField, Example{})).
    	  WithHelp(Example{}.Help()),

[liggitt]

Opened #938 to add this support

/transfer controller-tools