Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⚠️ Bump controller-runtime to 0.16.1 #352

Merged
merged 5 commits into from
Sep 13, 2023
Merged

⚠️ Bump controller-runtime to 0.16.1 #352

merged 5 commits into from
Sep 13, 2023

Conversation

justinsb
Copy link
Contributor

  • Update controller-runtime to 0.16.1
  • Update code for controller-runtime 0.16.0
  • Deprecate client-side validation in the direct applier

⚠️ Client-side validation is now deprecated in the direct applier. Server-side validation should be used instead, please open an issue if you have a use-case for client-side validation.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 11, 2023
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 11, 2023
@justinsb
Update code for controller-runtime 0.16.0
a825280 
Minor changes
@justinsb
Deprecate client-side validation in the direct applier
b083920 
The kube 1.28 libraries made client-side validation much harder.

We should be using server-side validation anyway.
@justinsb justinsb force-pushed the bump_controller_runtime_to_0_16 branch from a28bcba to b083920 Compare September 11, 2023 19:14
yuwenma
yuwenma reviewed Sep 13, 2023
View reviewed changes
.github/workflows/main.yml
@@ -47,7 +47,7 @@ jobs:

- uses: actions/checkout@v2

- run: go mod tidy
- run: dev/format-gomod
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's nit.

yuwenma
yuwenma approved these changes Sep 13, 2023
View reviewed changes
Copy link
Contributor

@yuwenma yuwenma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you for keeping this up-to-date with controller-runtime.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb, yuwenma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yuwenma
Copy link
Contributor

yuwenma commented Sep 13, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 13, 2023
@k8s-ci-robot k8s-ci-robot merged commit 67b1614 into kubernetes-sigs:master Sep 13, 2023
@ChristopherFry ChristopherFry mentioned this pull request Oct 23, 2023
Merged
@annasong20 annasong20 mentioned this pull request Nov 30, 2023
Merged
@Neo2308 Neo2308 mentioned this pull request Jan 7, 2024
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuwenma yuwenma yuwenma approved these changes

@atoato88 atoato88 Awaiting requested review from atoato88

@johnsonj johnsonj Awaiting requested review from johnsonj

Assignees

@yuwenma yuwenma

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@justinsb @k8s-ci-robot @yuwenma