Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump kubectl-fuzzy version to v1.9.0 #1231

Merged
merged 1 commit into from
Apr 24, 2021
Merged

Bump kubectl-fuzzy version to v1.9.0 #1231

merged 1 commit into from
Apr 24, 2021

Conversation

d-kuro
Copy link
Contributor

@d-kuro d-kuro commented Apr 24, 2021

@ahmetb
Copy link
Member

ahmetb commented Apr 24, 2021

🤖 Beep beep! I’m a robot speaking on behalf of @ahmetb. 🤖

This pull request does not seem to be a straightforward version bump. I'll have a human review this.

Why wasn't this detected as a plugin version bump:

file plugins/fuzzy.yaml is not a straightforward version bump: change on line 7 does not seem like a version bump: [+ bin: kubectl-fuzzy]

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 24, 2021
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 24, 2021
d-kuro
d-kuro commented Apr 24, 2021
View reviewed changes
plugins/fuzzy.yaml
Comment on lines +19 to +30
- uri: "https://github.com/d-kuro/kubectl-fuzzy/releases/download/v1.9.0/kubectl-fuzzy_1.9.0_darwin_arm64.tar.gz"
sha256: "3acb9ad298d6b1c965545f1168c073e8ae07592cd5ebe1929f56f5eae8a22f68"
bin: kubectl-fuzzy
files:
- from: kubectl-fuzzy
to: .
- from: LICENSE
to: .
selector:
matchLabels:
os: darwin
arch: arm64
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added darwin/arm64 build

@d-kuro
Copy link
Contributor Author

d-kuro commented Apr 24, 2021

/assign @chriskim06

@chriskim06
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 24, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chriskim06, d-kuro

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 24, 2021
@k8s-ci-robot k8s-ci-robot merged commit dfa1cd0 into kubernetes-sigs:master Apr 24, 2021
@d-kuro d-kuro deleted the d-kuro/bump-fuzzy branch April 24, 2021 15:15
@int128 int128 mentioned this pull request Nov 28, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chriskim06 chriskim06 Awaiting requested review from chriskim06

@corneliusweig corneliusweig Awaiting requested review from corneliusweig

Assignees

@chriskim06 chriskim06

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@d-kuro @ahmetb @chriskim06 @k8s-ci-robot