Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: rename cgroup2.yaml to vm.yaml #3485

Merged
merged 1 commit into from
Jan 21, 2024
Merged

CI: rename cgroup2.yaml to vm.yaml #3485

merged 1 commit into from
Jan 21, 2024

Conversation

AkihiroSuda
Copy link
Member

"cgroup2.yaml" is becoming misnomer, as PR #3409 is going to enable native ubuntu-22.04 runners with cgroup2.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 21, 2024
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 21, 2024
@aojea
Copy link
Contributor

aojea commented Jan 21, 2024

we don't want to do platform validation, only functionality, I thought we were only using Fedora because of the lack of cgroupsv2, if we are going to have them natively why we need a Fedora runner? can we run the rootless tests on the new runners?

@AkihiroSuda
Copy link
Member Author

AkihiroSuda commented Jan 21, 2024 •
edited
Loading

we don't want to do platform validation, only functionality, I thought we were only using Fedora because of the lack of cgroupsv2, if we are going to have them natively why we need a Fedora runner? can we run the rootless tests on the new runners?

Fedora is also used for covering SELinux, btrfs, newer kernel, etc.
While It is possible to run the rootless tests on the native ubuntu-22.04 runners, I suggest to keep Fedora as well.

@aojea
Copy link
Contributor

aojea commented Jan 21, 2024

Fedora is also used for covering SELinux, btrfs, newer kernel, etc.
While It is possible to run the rootless tests on the native ubuntu-22.04 runners, I suggest to keep Fedora as well.

fair enough but I'd prefer to be more neutral to distros, can we come up with another name that represents these features more generically? cutting-edge features, advanced features , ...

@AkihiroSuda
Copy link
Member Author

Fedora is also used for covering SELinux, btrfs, newer kernel, etc.
While It is possible to run the rootless tests on the native ubuntu-22.04 runners, I suggest to keep Fedora as well.

fair enough but I'd prefer to be more neutral to distros, can we come up with another name that represents these features more generically? cutting-edge features, advanced features , ...

What about just calling it "vm"?

@aojea
Copy link
Contributor

aojea commented Jan 21, 2024

ok

@AkihiroSuda
CI: rename cgroup2.yaml to vm.yaml
a9a6617 
"cgroup2.yaml" is becoming misnomer, as PR 3409 is going to enable native
ubuntu-22.04 runners with cgroup2.

Signed-off-by: Akihiro Suda <[email protected]>
@AkihiroSuda AkihiroSuda changed the title CI: rename cgroup2.yaml to fedora.yaml CI: rename cgroup2.yaml to vm.yaml Jan 21, 2024
@aojea
Copy link
Contributor

aojea commented Jan 21, 2024

/lgtm
/approve
Thanks

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 21, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AkihiroSuda, aojea

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 21, 2024
@k8s-ci-robot k8s-ci-robot merged commit ad3437c into kubernetes-sigs:main Jan 21, 2024
27 checks passed
@aojea aojea mentioned this pull request Jun 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aojea aojea Awaiting requested review from aojea

@neolit123 neolit123 Awaiting requested review from neolit123

Assignees

@aojea aojea

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AkihiroSuda @aojea @k8s-ci-robot