-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use main branch as the stable branch in Ingress demo #2368
Conversation
/cc @strongjz |
@rikatz: GitHub didn't allow me to request PR reviews from the following users: strongjz. Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
I can't follow, once you release v1 do we need to change again this file? |
Nope, we are going to use the main branch as the stable once we release v1. So I'm going to merge the v1 branch into main branch, and we can add a note to people using k8s < v1.19 to point to the deprecated branch (which is called release-v1beta1 but we are going to find a better naming) |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder, rikatz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks Ricardo for the hard work |
We've renamed master to main (actually created a new one, over the stable branch and not the development branch).
So now we can use again the file present directly in main branch, assuming main is going to be the stable and that as soon as we release Ingress v1 that branch is gonna get merged into this one