chore: Remove dynamic log level changing with ConfigMap watch #544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathan-innis
force-pushed
the
add-static-logging-config
branch
from
725cf8c to
9b09948
Compare
Pull Request Test Coverage Report for Build 6332239789
💛 - Coveralls |
jonathan-innis
force-pushed
the
add-static-logging-config
branch
3 times, most recently
from
86364eb to
5c24451
Compare
jonathan-innis
force-pushed
the
add-static-logging-config
branch
9 times, most recently
from
fc0886b to
f9b44b6
Compare
jonathan-innis
force-pushed
the
add-static-logging-config
branch
from
f9b44b6 to
b97ab0e
Compare
njtran
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #N/A
Description
This PR removes the ability for changes to be made to the
config-loggingConfigMap while the component is running. There has been planned deprecation for dropping support for this for some time, with the plan to drop knative as a dependency from the repository #332This change also makes the
WEBHOOK_METRICS_PORTenvironment variable a first-class citizen for getting webhook metrics as long as the webhooks are enabled.How was this change tested?
make presubmitBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.