Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Bump operatorpkg to include object based metrics #1814

Merged
merged 1 commit into from
Nov 15, 2024
Merged

chore: Bump operatorpkg to include object based metrics #1814

merged 1 commit into from
Nov 15, 2024

Conversation

engedaam
Copy link
Contributor

@engedaam engedaam commented Nov 15, 2024 •
edited
Loading

Fixes #N/A

Description

  • Bump operatorpkg package to include object based metrics. The new auto generated metrics will look as such:
    operator_<object kind>_status_condition_transitions_total
    operator_<object kind>_status_condition_transition_seconds
    operator_<object kind>_status_condition_current_status_seconds
    operator_<object kind>_status_condition_count
    operator_<object kind>_termination_current_time_seconds
    operator_<object kind>_termination_duration_seconds

How was this change tested?

  • N/A

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 15, 2024
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 15, 2024
@engedaam engedaam force-pushed the add-object-based-metrics branch from 5eeac57 to 7a44278 Compare November 15, 2024 17:36
@engedaam engedaam force-pushed the add-object-based-metrics branch from 7a44278 to b79d438 Compare November 15, 2024 17:46
jonathan-innis
jonathan-innis approved these changes Nov 15, 2024
View reviewed changes
Copy link
Member

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 15, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: engedaam, jonathan-innis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 15, 2024
@k8s-ci-robot k8s-ci-robot merged commit 995040b into kubernetes-sigs:main Nov 15, 2024
12 checks passed
@engedaam engedaam deleted the add-object-based-metrics branch November 15, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathan-innis jonathan-innis jonathan-innis approved these changes

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

@jmdeal jmdeal Awaiting requested review from jmdeal

Assignees

@jonathan-innis jonathan-innis

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@engedaam @k8s-ci-robot @jonathan-innis