Add --no-cleanup option to iptables-wrapper-installer.sh

[yoheiueda]

Cache mounts of Docker builds are useful to share artifacts among multi-stage builds, but the cleanup mechanism of iptables-wrapper-installer.sh does not work well with cache mounts.

This patch adds a new option --no-cleanup to suppress cleanup of iptables-wrapper binary and iptables-wrapper-installer.sh.

We can use this option to build a container image with a cache mount as follows.

FROM golang:bookworm as builder

RUN git clone -b no-cleanup https://github.com/yoheiueda/iptables-wrappers.git /work
WORKDIR /work
RUN make BIN_DIR=/work build

FROM  debian:bookworm

RUN apt-get update && apt-get -y install iptables

RUN --mount=type=cache,target=/work,from=builder,source=/work,readonly \
	cd /work && ./iptables-wrapper-installer.sh --no-cleanup

[k8s-ci-robot]

Welcome @yoheiueda!

It looks like this is your first PR to kubernetes-sigs/iptables-wrappers 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/iptables-wrappers has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[danwinship]

ok

[danwinship]

Suggested change

	if [ -z "$no_sanity_check" ]; then
	if [ -z "${no_sanity_check}" ]; then

for consistency. (Bash scripts in k8s always do it that way... I think the idea is that you need the braces in some cases (like if there's text that comes directly after the variable expansion with no space between them) and it's better/more consistent to just always use the braces.)

(likewise with no_cleanup below)

[yoheiueda]

Done

[danwinship]

You could also just always do "cp" rather than "mv" here, and then rm the original in the "# Cleanup" section below

[yoheiueda]

Done

[danwinship]

/lgtm
/approve

thanks!

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danwinship, yoheiueda

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [danwinship]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment