Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Google GCE provider #148

Merged
merged 4 commits into from
Jun 7, 2024
Merged

Add support for Google GCE provider #148

merged 4 commits into from
Jun 7, 2024

Conversation

sawsa307
Copy link
Contributor

@sawsa307 sawsa307 commented Mar 30, 2024 •
edited
Loading

What type of PR is this?
/kind documentation
/kind feature

What this PR does / why we need it:
Adds initial support for GCE provider. Will improve to add more features.

Which issue(s) this PR fixes:
First PR to address issue #87. New features will be added in the following PRs.

Does this PR introduce a user-facing change?:

Added initial support for GCE provider.

@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. kind/feature Categorizes issue or PR as related to a new feature. labels Mar 30, 2024
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 30, 2024
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 30, 2024
@sawsa307 sawsa307 marked this pull request as draft March 30, 2024 21:23
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 30, 2024
@sawsa307 sawsa307 force-pushed the gce-provider-init branch from f7a8584 to 9d05a0f Compare March 31, 2024 10:32
@sawsa307 sawsa307 force-pushed the gce-provider-init branch from 9d05a0f to 89f1f74 Compare March 31, 2024 10:34
@sawsa307 sawsa307 marked this pull request as ready for review March 31, 2024 10:35
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 31, 2024
@sawsa307
Copy link
Contributor Author

/assign @robscott @LiorLieberman

@sawsa307 sawsa307 changed the title Gce provider init Initial commit for GCE provider Mar 31, 2024
@sawsa307 sawsa307 force-pushed the gce-provider-init branch from 89f1f74 to 7c01de1 Compare March 31, 2024 21:27
@sawsa307 sawsa307 force-pushed the gce-provider-init branch from 7c01de1 to 021e7e1 Compare April 1, 2024 21:56
@sawsa307 sawsa307 force-pushed the gce-provider-init branch from 021e7e1 to aaf22f0 Compare April 1, 2024 22:04
mlavacca
mlavacca reviewed Apr 2, 2024
View reviewed changes
@sawsa307 sawsa307 force-pushed the gce-provider-init branch from aaf22f0 to 65d4753 Compare April 2, 2024 20:05
@sawsa307 sawsa307 force-pushed the gce-provider-init branch from 65d4753 to 08b45de Compare April 2, 2024 20:15
@sawsa307
Copy link
Contributor Author

Resolved comments and ready for another round of review. PTAL! @robscott @LiorLieberman

@sawsa307
Copy link
Contributor Author

sawsa307 commented Jun 3, 2024

Hi @mlavacca @LiorLieberman did you get a chance to look into this?

@LiorLieberman LiorLieberman changed the title Initial commit for GCE provider Add support for Google GCE provider Jun 5, 2024
LiorLieberman
LiorLieberman reviewed Jun 5, 2024
View reviewed changes
Copy link
Member

@LiorLieberman LiorLieberman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet, thanks @sawsa307 !
Looks good overall, I left a few nits.
Also, can you update the PR description and add the provider to the main readme file?

@sawsa307 sawsa307 force-pushed the gce-provider-init branch from c58ad98 to 08ea688 Compare June 6, 2024 19:22
@sawsa307 sawsa307 force-pushed the gce-provider-init branch from 08ea688 to 5f1d5fd Compare June 6, 2024 19:36
@sawsa307 sawsa307 force-pushed the gce-provider-init branch from 5f1d5fd to 4674ee3 Compare June 6, 2024 19:41
@sawsa307 sawsa307 force-pushed the gce-provider-init branch from 4674ee3 to c7e71b0 Compare June 6, 2024 20:28
@sawsa307 sawsa307 force-pushed the gce-provider-init branch from c7e71b0 to 0ed657f Compare June 6, 2024 20:31
LiorLieberman
LiorLieberman approved these changes Jun 7, 2024
View reviewed changes
Copy link
Member

@LiorLieberman LiorLieberman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last comment about using set and not slice.
I am going to approve and ping me when its ready for lgtm. (If I give you lgtm now, it will become obsolete once you push another commit.)

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LiorLieberman, sawsa307

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 7, 2024
@sawsa307 sawsa307 force-pushed the gce-provider-init branch from 0ed657f to ea90057 Compare June 7, 2024 19:47
@LiorLieberman
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 7, 2024
@k8s-ci-robot k8s-ci-robot merged commit 143ae87 into kubernetes-sigs:main Jun 7, 2024
5 checks passed
@sawsa307 sawsa307 mentioned this pull request Jun 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robscott robscott robscott left review comments

@LiorLieberman LiorLieberman LiorLieberman approved these changes

@levikobi levikobi Awaiting requested review from levikobi

@spencerhance spencerhance Awaiting requested review from spencerhance

@mlavacca mlavacca Awaiting requested review from mlavacca

Assignees

@robscott robscott

@LiorLieberman LiorLieberman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sawsa307 @LiorLieberman @k8s-ci-robot @spencerhance @robscott @mlavacca