Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: bump ReferenceGrant to v1beta1 #142

Merged
merged 1 commit into from
Mar 29, 2024
Merged

feat: bump ReferenceGrant to v1beta1 #142

merged 1 commit into from
Mar 29, 2024

Conversation

YTGhost
Copy link
Contributor

@YTGhost YTGhost commented Mar 8, 2024 •
edited
Loading

What type of PR is this?
/kind feature

What this PR does / why we need it:
ReferenceGrant has been promoted to v1beta1 but we are still using the alpha version. We should bump the API.

Which issue(s) this PR fixes:

Fixes #140

Does this PR introduce a user-facing change?:

Bump `ReferenceGrant` to `v1beta1`

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 8, 2024
@k8s-ci-robot k8s-ci-robot requested review from levikobi and Xunzhuo March 8, 2024 12:53
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 8, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @YTGhost. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 8, 2024
@YTGhost YTGhost force-pushed the feat-bump-ReferenceGrant-to-v1beta1 branch from 0731efb to f615d0f Compare March 8, 2024 12:55
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 8, 2024
@YTGhost
Copy link
Contributor Author

YTGhost commented Mar 8, 2024

Hi @mlavacca @LiorLieberman PTAL

levikobi
levikobi reviewed Mar 10, 2024
View reviewed changes
Copy link
Member

@levikobi levikobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @YTGhost!
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 10, 2024
mlavacca
mlavacca requested changes Mar 11, 2024
View reviewed changes
Copy link
Member

@mlavacca mlavacca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR, @YTGhost! In addition to what's in this PR, I found some more gatewayv1alpha1.ReferenceGrant references that need to be changed as well:

https://github.com/kubernetes-sigs/ingress2gateway/blob/main/pkg/i2gw/providers/common/converter.go#L94-L98

https://github.com/kubernetes-sigs/ingress2gateway/blob/main/pkg/i2gw/providers/istio/converter_test.go#L1593-L1619

https://github.com/kubernetes-sigs/ingress2gateway/blob/main/pkg/i2gw/providers/istio/converter.go#L978-L1026

@YTGhost YTGhost force-pushed the feat-bump-ReferenceGrant-to-v1beta1 branch from f615d0f to 7a93396 Compare March 11, 2024 13:14
@YTGhost
Copy link
Contributor Author

YTGhost commented Mar 11, 2024

Thanks for this PR, @YTGhost! In addition to what's in this PR, I found some more gatewayv1alpha1.ReferenceGrant references that need to be changed as well:

https://github.com/kubernetes-sigs/ingress2gateway/blob/main/pkg/i2gw/providers/common/converter.go#L94-L98

https://github.com/kubernetes-sigs/ingress2gateway/blob/main/pkg/i2gw/providers/istio/converter_test.go#L1593-L1619

https://github.com/kubernetes-sigs/ingress2gateway/blob/main/pkg/i2gw/providers/istio/converter.go#L978-L1026

Hi, @mlavacca , thank you for your review! I have also checked this PR again and found some other areas that need modification. I believe this PR should now be complete.

@LiorLieberman
Copy link
Member

/cc @mlavacca
Can you take another look?

@k8s-ci-robot k8s-ci-robot requested a review from mlavacca March 27, 2024 11:54
@LiorLieberman
Copy link
Member

@YTGhost can you add release note?

@YTGhost
Copy link
Contributor Author

YTGhost commented Mar 27, 2024

@YTGhost can you add release note?

Okay

mlavacca
mlavacca approved these changes Mar 28, 2024
View reviewed changes
Copy link
Member

@mlavacca mlavacca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @YTGhost!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 28, 2024
@LiorLieberman
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LiorLieberman, mlavacca, YTGhost

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 28, 2024
@YTGhost YTGhost force-pushed the feat-bump-ReferenceGrant-to-v1beta1 branch from 7a93396 to cfd09c9 Compare March 28, 2024 15:12
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 28, 2024
@YTGhost
Copy link
Contributor Author

YTGhost commented Mar 28, 2024

@LiorLieberman Sorry for the missing modification in the last gatewayv1alpha2.ReferenceGrant in pkg/i2gw/ingress2gateway.go. PTAL.

@mlavacca
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 29, 2024
@k8s-ci-robot k8s-ci-robot merged commit 71f5b49 into kubernetes-sigs:main Mar 29, 2024
4 checks passed
xtineskim pushed a commit to xtineskim/ingress2gateway that referenced this pull request Apr 23, 2024
@YTGhost @xtineskim
feat: bump ReferenceGrant to v1beta1 (kubernetes-sigs#142)
b0d246e 
Signed-off-by: Liang Deng <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@levikobi levikobi levikobi left review comments

@mlavacca mlavacca mlavacca approved these changes

@Xunzhuo Xunzhuo Awaiting requested review from Xunzhuo

Assignees

@mlavacca mlavacca

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bump ReferenceGrant to v1beta1
5 participants
@YTGhost @k8s-ci-robot @LiorLieberman @mlavacca @levikobi