Use external provisioner 2.0.x which provides a default-fstype flag

[saikat-royc]

Use external provisioner change which provides a default-fstype flag. For filestore driver this should be set to 'nfs'.

Also have stricter check in ValidateVolumeCapabilities for fstype == 'nfs'.
https://github.com/kubernetes-sigs/gcp-filestore-csi-driver/blob/master/pkg/csi_driver/gcfs_driver.go#L154

Current implementation ignores the fstype passed by the CSI calls, and uses hard coded nfs type in mount operation.
https://github.com/kubernetes-sigs/gcp-filestore-csi-driver/blob/master/pkg/csi_driver/node.go#L216

[saikat-royc]

/assign

[msau42]

Unsure if we should set a fstype. Then it may be hard to switch between nfs and smb in protocols in the future

[saikat-royc]

Smb type shares can be provided in the SC, which would override the default fstype set in provisioner. Thoughts?

[msau42]

I think a single share can support both smb or nfs and can dynamically decide which it wants to use depending on which OS it's being mounted on. I'm not sure I see a need for restricting the type on the PV yet.

In the CSI spec, we intended "" fstype for nfs-type systems.

[saikat-royc]

Ok so when we upgrade provisioner th 2.0.x we should be getting "" fstype in the volume capability.

[msau42]

correct

…

On Mon, Sep 28, 2020 at 5:22 PM Saikat Roychowdhury < ***@***.***> wrote: Ok so when we upgrade provisioner th 2.0.x we should be getting "" fstype in the volume capability. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#60 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AF2QYPOPYZKNPSTDOPV7SNLSIESETANCNFSM4R5AT7NQ> .

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[fejta-bot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-contributor-experience at kubernetes/community.
/close

[k8s-ci-robot]

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-contributor-experience at kubernetes/community.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.