refactor codegen scripts to make it easier to generate two clients #3589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
the
size/L
|
note - the order of the versions is changed in the clients because of it's the order (from |
|
This is ready |
k8s-ci-robot
added
the
needs-rebase
dprotaso
force-pushed
the
refactor-code-gen
branch
from
00e8eaa to
e41035d
Compare
k8s-ci-robot
removed
the
needs-rebase
shaneutt
approved these changes
Feb 11, 2025
k8s-ci-robot
added
the
approved
robscott
approved these changes
Feb 12, 2025
Comment on lines
+47
to
+53
| if [[ "${1:-stable}" == "experimental" ]]; then | ||
| readonly OUTPUT_DIR=pkg/clientx | ||
| readonly OUTPUT_PKG=sigs.k8s.io/gateway-api/pkg/clientx | ||
| else | ||
| readonly OUTPUT_DIR=pkg/client | ||
| readonly OUTPUT_PKG=sigs.k8s.io/gateway-api/pkg/client | ||
| fi |
There was a problem hiding this comment.
I'm a little curious if a single clientset would be better here. With that said, this will likely become clearer as we start working with ListenerSet. I'm fine with this as a starting point.
There was a problem hiding this comment.
yeah this can be adjusted later
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, robscott, shaneutt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
needs-rebase
dprotaso
force-pushed
the
refactor-code-gen
branch
from
e41035d to
7ccff29
Compare
k8s-ci-robot
removed
the
lgtm
|
New changes are detected. LGTM label has been removed. |
k8s-ci-robot
removed
the
needs-rebase
shaneutt
added
the
lgtm
EyalPazz
pushed a commit
to EyalPazz/gateway-api
that referenced
this pull request
Feb 16, 2025
…ubernetes-sigs#3589) * refactor codegen scripts to make it easier to generate two clients * add some newlines * fix find invocation use -maxdepth and not -depth * include requested comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies the ListenerSet APIs PR
#3588
Release Note