Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change repo name? #536

Closed
bowei opened this issue Jan 25, 2021 · 11 comments · Fixed by #541
Closed

Change repo name? #536

bowei opened this issue Jan 25, 2021 · 11 comments · Fixed by #541
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Milestone

Comments

@bowei
Copy link
Contributor

bowei commented Jan 25, 2021

Should we change the name of the repo to align with the primary resource names (gateway-apis?)

@bowei bowei added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 25, 2021
@mark-church
Copy link
Contributor

Could we not pluralize it though? When it's plural everybody tends to call it something different (service api vs service apis). It would be a bit more concrete if it was just gateway-api.

@SantoDE
Copy link
Contributor

SantoDE commented Jan 26, 2021

I am so much in favour of gateway-api then :)

@hbagdi
Copy link
Contributor

hbagdi commented Jan 26, 2021

@bowei Before we get into renaming, I think we should understand why the current name was chosen in the first place. What was the motivation and goal then?

@bowei
Copy link
Contributor Author

bowei commented Jan 26, 2021

I chose the name because it has to do with an API that was an iteration on Kubernetes services.

At that point in time, we didn't really have any of the resource names, so I didn't really want to make up a name.

@robscott
Copy link
Member

robscott commented Jan 26, 2021

Although the plural APIs name feels more accurate, I think the singular Gateway API name would likely be easier to work with. Name changes are always painful, but I think the transition from Service to Gateway probably makes sense here. Certainly will be easier to change the project name now than at any point in the future. With that said I'm sure it would be a non-trivial amount of work.

@robscott
Copy link
Member

/cc @danehans @jpeach

@robscott
Copy link
Member

Of course this would be a terrible change if we weren't 100% sold on the Gateway name. I think our votes on resource naming in the fall were pretty conclusive though.
Screen Shot 2021-01-26 at 10 44 02 AM

@danehans
Copy link
Contributor

@bowei what is the impetus for the name change? Renaming to Gateway API implies a single API. I'm in favor of keeping the name unless the current name does not follow a standardized k8s repo naming schema.

@danehans
Copy link
Contributor

@bowei will send an email to the sig-network mailer to obtain feedback on the rename. This issue will be readdressed during the 2/3 service apis community meeting.

@robscott
Copy link
Member

Thread in sig-network mailing list: https://groups.google.com/g/kubernetes-sig-network/c/5Rkg_juNDGc. Also added to agenda for sig-network meeting on Feb 4.

robscott added a commit to robscott/gateway-api that referenced this issue Feb 10, 2021
As discussed in kubernetes-sigs#536, Gateway API more clearly represents this project
now.
robscott added a commit to robscott/gateway-api that referenced this issue Feb 11, 2021
As discussed in kubernetes-sigs#536, Gateway API more clearly represents this project
now.
@hbagdi hbagdi added this to the v0.2.0 milestone Feb 11, 2021
@hbagdi
Copy link
Contributor

hbagdi commented Feb 11, 2021

/assign @robscott

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

6 participants