fix: distinct address types for Gateways

Re-using the Gateway AddressType ended up having
problems because it would add extraneous CRD fields,
so this patch creates a new type specifically for
this purpose with single-purpose validation options.

apis/v1alpha2/gateway_types.go

@@ -450,7 +450,7 @@ type GatewayAddress struct {
 	//
 	// +optional
 	// +kubebuilder:default=IPAddress
-	Type *AddressType `json:"type,omitempty"`
+	Type *GatewayAddressType `json:"type,omitempty"`
 
 	// Value of the address. The validity of the values will depend
 	// on the type and support by the controller.
@@ -462,14 +462,16 @@ type GatewayAddress struct {
 	Value string `json:"value"`
 }
 
-// AddressType defines how a network address is represented as a text string.
+// GatewayAddressType defines how a network address is represented as a text
+// string, specifically in the context of listener addresses for Gateways and
+// includes options over the base AddressType type such as Hostname.
 //
 // If the requested address is unsupported, the controller
 // should raise the "Detached" listener status condition on
 // the Gateway with the "UnsupportedAddress" reason.
 //
 // +kubebuilder:validation:Enum=IPAddress;Hostname;NamedAddress
-type AddressType string
+type GatewayAddressType string
 
 const (
 	// A textual representation of a numeric IP address. IPv4
@@ -482,22 +484,22 @@ const (
 	// IPAddress).
 	//
 	// Support: Extended
-	IPAddressType AddressType = "IPAddress"
+	IPAddressType GatewayAddressType = "IPAddress"
 
 	// A Hostname represents a DNS based ingress point. This is similar to the
 	// corresponding hostname field in Kubernetes load balancer status. For
 	// example, this concept may be used for cloud load balancers where a DNS
 	// name is used to expose a load balancer.
 	//
 	// Support: Extended
-	HostnameAddressType AddressType = "Hostname"
+	HostnameAddressType GatewayAddressType = "Hostname"
 
 	// A NamedAddress provides a way to reference a specific IP address by name.
 	// For example, this may be a name or other unique identifier that refers
 	// to a resource on a cloud provider such as a static IP.
 	//
 	// Support: Implementation-Specific
-	NamedAddressType AddressType = "NamedAddress"
+	NamedAddressType GatewayAddressType = "NamedAddress"
 )
 
 // GatewayStatus defines the observed state of Gateway.

apis/v1alpha2/shared_types.go

@@ -414,8 +414,6 @@ type AddressMatch struct {
 	// Support: Custom (NamedAddress)
 	//
 	// +optional
-	// +kubebuilder:validation:Enum=IPAddress;NamedAddress
-	// +kubebuilder:default=IPAddress
 	Type *AddressType `json:"type,omitempty"`
 
 	// Value of the address. The validity of the values will depend
@@ -434,3 +432,9 @@ type AddressMatch struct {
 	// +kubebuilder:validation:MaxLength=253
 	Value string `json:"value"`
 }
+
+// AddressType defines how a network address is represented as a text string.
+//
+// +kubebuilder:validation:Enum=IPAddress;NamedAddress
+// +kubebuilder:default=IPAddress
+type AddressType string