Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dependency on dnscontrol #3941

Merged
merged 7 commits into from
Sep 20, 2023
Merged

Remove dependency on dnscontrol #3941

merged 7 commits into from
Sep 20, 2023

Conversation

TomOnTime
Copy link
Contributor

Description

Eliminate the dependency on dnscontrol. The infoblox provider imports dnscontrol solely to use one function. go.mod lists a version of dnscontrol that was recalled.

Fixes #3887

Checklist

  • Unit tests updated
  • End user documentation updated

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 17, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Sep 17, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @TomOnTime!

It looks like this is your first PR to kubernetes-sigs/external-dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/external-dns has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @TomOnTime. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 17, 2023
johngmyers
johngmyers reviewed Sep 17, 2023
View reviewed changes
Copy link
Contributor

@johngmyers johngmyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

pkg/rfc2317/arpa.go Outdated
ip := net.ParseIP(cidr)
if ip != nil {
if ip.To4() != nil {
cidr = cidr + "/32"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this produces incorrect results for IPv4-mapped IPv6 addresses.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

pkg/rfc2317/arpa_test.go Outdated
func TestCidrToInAddr(t *testing.T) {
var tests = []struct {
in string
isError bool
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer having this be a string, with the test asserting that the returned error has the specified message.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 17, 2023
@johngmyers
Copy link
Contributor

Please sign the CLA as instructed.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Sep 17, 2023
@TomOnTime
Copy link
Contributor Author

@johngmyers I have signed the CLA as instructed. Can you verify it went through? I suspect EasyCLA confused my two Github accounts.

johngmyers
johngmyers suggested changes Sep 19, 2023
View reviewed changes
pkg/rfc2317/arpa.go Outdated Show resolved Hide resolved
pkg/rfc2317/arpa_test.go Outdated Show resolved Hide resolved
TomOnTime and others added 2 commits September 19, 2023 16:07
@TomOnTime @johngmyers
Update pkg/rfc2317/arpa.go
49d4a84 
Co-authored-by: John Gardiner Myers <[email protected]>
@TomOnTime @johngmyers
Update pkg/rfc2317/arpa_test.go
d0279e7 
Co-authored-by: John Gardiner Myers <[email protected]>
TomOnTime
TomOnTime commented Sep 19, 2023
View reviewed changes
pkg/rfc2317/arpa_test.go Outdated Show resolved Hide resolved
TomOnTime
TomOnTime commented Sep 19, 2023
View reviewed changes
pkg/rfc2317/arpa_test.go Outdated Show resolved Hide resolved
@TomOnTime
Copy link
Contributor Author

I've addressed all the concerns. PTAL

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 20, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johngmyers

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 20, 2023
@k8s-ci-robot k8s-ci-robot merged commit 6e4f5b7 into kubernetes-sigs:master Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johngmyers johngmyers johngmyers approved these changes

@njuettner njuettner Awaiting requested review from njuettner

Assignees

@johngmyers johngmyers

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove dependency on DNSControl
4 participants
@TomOnTime @k8s-ci-robot @johngmyers @tlimoncelli